Bug 47871 - Need to include WKErrorRef in the WKPageDidFail... functions
Summary: Need to include WKErrorRef in the WKPageDidFail... functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-10-18 19:01 PDT by Sam Weinig
Modified: 2010-10-19 10:16 PDT (History)
2 users (show)

See Also:


Attachments
Patch (34.50 KB, patch)
2010-10-18 19:05 PDT, Sam Weinig
mitz: review+
Details | Formatted Diff | Diff
Part two. (20.78 KB, patch)
2010-10-19 10:05 PDT, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-10-18 19:01:51 PDT
We need to fix the FIXME in WKPage.h and add WKErrorRef parameters to the WKPageDidFail... functions.
Comment 1 Sam Weinig 2010-10-18 19:02:05 PDT
<rdar://problem/8564110>
Comment 2 Sam Weinig 2010-10-18 19:05:04 PDT
Created attachment 71114 [details]
Patch
Comment 3 Early Warning System Bot 2010-10-18 19:13:41 PDT
Attachment 71114 [details] did not build on qt:
Build output: http://queues.webkit.org/results/4423076
Comment 4 Sam Weinig 2010-10-19 10:05:47 PDT
Created attachment 71179 [details]
Part two.
Comment 5 WebKit Review Bot 2010-10-19 10:09:28 PDT
Attachment 71179 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/Shared/WebError.cpp:27:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Sam Weinig 2010-10-19 10:16:21 PDT
Part 1 landed in http://trac.webkit.org/changeset/70062.
Part 2 landed in http://trac.webkit.org/changeset/70066.