Bug 47867 - new-run-webkit-tests produces corrupt PNG baselines on Windows
Summary: new-run-webkit-tests produces corrupt PNG baselines on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-18 18:49 PDT by Kenneth Russell
Modified: 2010-10-18 20:00 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.26 KB, patch)
2010-10-18 18:52 PDT, Kenneth Russell 		eric: review+
kbr: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-10-18 18:49:00 PDT 
new-run-webkit-tests produces corrupt PNG baselines on Windows, at least with the Python from http://www.python.org/, because the output file is opened with mode "w" rather than mode "wb" in WebKitTools/Scripts/webkitpy/layout_tests/port/base.py, update_baseline. Like _expected_file_contents in the same file, the encoding should be tested and "b" used if the encoding is None.
Comment 1 Kenneth Russell 2010-10-18 18:52:45 PDT 
Created attachment 71111 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-10-18 18:54:44 PDT 
Comment on attachment 71111 [details]
Patch

I would have written "if not encoding:", but this is fine.
Comment 3 Kenneth Russell 2010-10-18 19:32:47 PDT 
Committed r70017: <http://trac.webkit.org/changeset/70017>
Comment 4 Eric Seidel (no email) 2010-10-18 19:38:10 PDT 
Committed r70019: <http://trac.webkit.org/changeset/70019>
Comment 5 WebKit Review Bot 2010-10-18 20:00:19 PDT 
http://trac.webkit.org/changeset/70017 might have broken SnowLeopard Intel Release (Tests)