new-run-webkit-tests produces corrupt PNG baselines on Windows, at least with the Python from http://www.python.org/, because the output file is opened with mode "w" rather than mode "wb" in WebKitTools/Scripts/webkitpy/layout_tests/port/base.py, update_baseline. Like _expected_file_contents in the same file, the encoding should be tested and "b" used if the encoding is None.
Created attachment 71111 [details]
Comment on attachment 71111 [details]
I would have written "if not encoding:", but this is fine.
Committed r70017: <http://trac.webkit.org/changeset/70017>
Committed r70019: <http://trac.webkit.org/changeset/70019>
http://trac.webkit.org/changeset/70017 might have broken SnowLeopard Intel Release (Tests)