RESOLVED FIXED 47867
new-run-webkit-tests produces corrupt PNG baselines on Windows 
https://bugs.webkit.org/show_bug.cgi?id=47867
Summary new-run-webkit-tests produces corrupt PNG baselines on Windows
Kenneth Russell
Reported 2010-10-18 18:49:00 PDT
new-run-webkit-tests produces corrupt PNG baselines on Windows, at least with the Python from http://www.python.org/, because the output file is opened with mode "w" rather than mode "wb" in WebKitTools/Scripts/webkitpy/layout_tests/port/base.py, update_baseline. Like _expected_file_contents in the same file, the encoding should be tested and "b" used if the encoding is None.
Attachments
Patch (1.26 KB, patch)
2010-10-18 18:52 PDT, Kenneth Russell 		eric: review+
kbr: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2010-10-18 18:52:45 PDT
Created attachment 71111 [details] Patch
Eric Seidel (no email)
Comment 2 2010-10-18 18:54:44 PDT
Comment on attachment 71111 [details] Patch I would have written "if not encoding:", but this is fine.
Kenneth Russell
Comment 3 2010-10-18 19:32:47 PDT
Committed r70017: <http://trac.webkit.org/changeset/70017>
Eric Seidel (no email)
Comment 4 2010-10-18 19:38:10 PDT
Committed r70019: <http://trac.webkit.org/changeset/70019>
WebKit Review Bot
Comment 5 2010-10-18 20:00:19 PDT
http://trac.webkit.org/changeset/70017 might have broken SnowLeopard Intel Release (Tests)
Note You need to log in before you can comment on or make changes to this bug.