Bug 47866 – Implement webkit-patch suggest-reviewers

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

Implement webkit-patch suggest-reviewers

[Adam Barth]

Created attachment 71109 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 71109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71109&action=review

Looks good to me.

I'm glad you beat me to it.  Nicely done. :)

> WebKitTools/Scripts/webkitpy/common/checkout/api.py:118
> +    def suggested_reviewers(self, git_commit):

I guess I figured Checkout would have had a more generic API (like the CommitInfos for the last N revisions), but OK.

[WebKit Commit Bot]

Comment on attachment 71109 [details]
Patch

Rejecting patch 71109 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 71109]" exit_code: 2
Cleaning working directory
Updating working directory
Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=71109&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=47866&ctype=xml
Processing 1 patch from 1 bug.
Processing patch 71109 from bug 47866.
Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/4414082

[Adam Barth]

Comment on attachment 71109 [details]
Patch

Oh noes!  Darn you commit-cluster!

[WebKit Commit Bot]

Comment on attachment 71109 [details]
Patch

Clearing flags on attachment: 71109

Committed r70020: <http://trac.webkit.org/changeset/70020>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ojan Vafai]

This is a great start. I was imagining that the way we'd implement this was to look at the annotate for the file at the lines modified and use those as the reviewers. That's what I do when I do it manually. WDYT?

[Eric Seidel (no email)]

(In reply to comment #7)
> This is a great start. I was imagining that the way we'd implement this was to look at the annotate for the file at the lines modified and use those as the reviewers. That's what I do when I do it manually. WDYT?

Yup.  We could do that.  That's what I originally started to do (and have a half-patch for).  But this solution is much simpler and gets us 90% of the way there it seems.

IF we're going to look at the individual lines, either we have to create a diff and use DiffParser, or we have to find some way to get modified line ranges out of git/svn w/o creating a patch.

The annotate step after that is easy.