Bug 47865 - Remove VisiblePosition from RenderTextControl
Summary: Remove VisiblePosition from RenderTextControl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Critical
Assignee: Nobody
URL:
Keywords:
Depends on: 47870 64118 64133 64134
Blocks:
  Show dependency tree / graph
 
Reported: 2010-10-18 17:39 PDT by Ryosuke Niwa
Modified: 2011-07-13 00:53 PDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2010-10-18 17:39:12 PDT 
RenderTextControl currently has many functions that instantiate VisiblePosition but this may cause layout and destroy the RenderTextControl itself.  We must remove this dependency as soon as possible.
Comment 1 Ryosuke Niwa 2011-07-13 00:53:14 PDT 
Now, the only member function of RenderTextControl that uses VisiblePosition is visiblePositionForIndex, which is inherited from RenderObject.  Since removing visiblePositionForIndex from RenderTextControl requires removing it from RenderObject, I consider this to be beyond the scope of this bug.