Bug 47853 – context-attributes-etc layout test should test against undefined, not null

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Adrienne Walker]

The LayoutTests/fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html test creates several contexts and then gets their creation attributes and tests that all the named attributes exist.  However, it is testing against null instead of undefined.  This should be fixed by adding this function to js-test-pre.js and pushing the new test and the js-test-pre.js file to the Khronos repository.

See: https://bugs.webkit.org/show_bug.cgi?id=47697 for more discussion.

[Adrienne Walker]

Created attachment 72202 [details]
Patch

[Adrienne Walker]

This change has already been pushed into the Khronos repository.  Additionally, the only test that needed to be changed was the window-property-descriptors expectations.  The other tests mentioned in bug 47697 did not appear to be affected, both from running the tests directly but also from inspection.

[Kenneth Russell]

Comment on attachment 72202 [details]
Patch

Looks good. I'm assuming you ran all of the layout tests affected by the addition of shouldBeDefined.

[WebKit Commit Bot]

Comment on attachment 72202 [details]
Patch

Clearing flags on attachment: 72202

Committed r70794: <http://trac.webkit.org/changeset/70794>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/70794 might have broken Qt Linux Release
The following tests are not passing:
fast/dom/Window/window-property-descriptors.html

[Adrienne Walker]

(In reply to comment #6)
> http://trac.webkit.org/changeset/70794 might have broken Qt Linux Release
> The following tests are not passing:
> fast/dom/Window/window-property-descriptors.html

Filed https://bugs.webkit.org/show_bug.cgi?id=48564 to fix this test.