RESOLVED FIXED 47840
Add matchCountDidChange callback 
https://bugs.webkit.org/show_bug.cgi?id=47840
Summary Add matchCountDidChange callback
Anders Carlsson
Reported 2010-10-18 11:30:32 PDT
Add matchCountDidChange callback
Attachments
Patch (9.26 KB, patch)
2010-10-18 11:33 PDT, Anders Carlsson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-10-18 11:33:28 PDT
Created attachment 71065 [details] Patch
Darin Adler
Comment 2 2010-10-18 11:34:50 PDT
Comment on attachment 71065 [details] Patch Side thought, not just about this patch: I’m not sure that a single boolean for case sensitivity is the right set of options for text finding. Since Safari only uses “case insensitive false” mode, the “case insensitive true” mode is for future use. Might we want some other searching modes for future use?
WebKit Review Bot
Comment 3 2010-10-18 11:35:23 PDT
Attachment 71065 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/UIProcess/API/C/WKPage.h:174: Extra space between WKPageMatchCountDidChangeCallback and matchCountDidChange [whitespace/declaration] [3] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 4 2010-10-18 11:47:32 PDT
Committed r69978: <http://trac.webkit.org/changeset/69978>
WebKit Review Bot
Comment 5 2010-10-18 12:36:41 PDT
http://trac.webkit.org/changeset/69978 might have broken Leopard Intel Debug (Tests)
Note You need to log in before you can comment on or make changes to this bug.