RESOLVED FIXED 47827
Web Inspector: disable private browsing for inspector 
https://bugs.webkit.org/show_bug.cgi?id=47827
Summary Web Inspector: disable private browsing for inspector
Pavel Podivilov
Reported 2010-10-18 09:25:54 PDT
Currently private browsing is enabled for inspector which makes localStorage inaccessible. Comment says it's done to keep inspector out of history, but even with private browsing disabled, inspector don't appear in history. Debugging safari showed that inspector's WebView doesn't have history delegate, but I'm not sure because history delegate is assigned in private safari code. Joseph, could you please check if inspector doesn't have history delegate and thus private browsing isn't needed for inspector?
Attachments
Patch. (2.37 KB, patch)
2010-10-18 09:28 PDT, Pavel Podivilov 		timothy: review+
podivilov: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2010-10-18 09:28:44 PDT
Created attachment 71046 [details] Patch.
Joseph Pecoraro
Comment 2 2010-10-18 09:41:52 PDT
Timothy would be more likely to know. I'll see what I can find.
Joseph Pecoraro
Comment 3 2010-10-18 09:45:33 PDT
By the way, your patch should remove the comment if it is no longer true. =)
Timothy Hatcher
Comment 4 2010-10-18 09:50:06 PDT
Comment on attachment 71046 [details] Patch. I do think this is correct now, since we have the history delegate concept and there isn't one hooked up to the Inspector. Assuming you tested and didn't see it show up in Safari's History menu.
Pavel Podivilov
Comment 5 2010-10-18 09:58:03 PDT
Comment on attachment 71046 [details] Patch. cq- to address Joseph's comment.
Pavel Podivilov
Comment 6 2010-10-18 10:22:23 PDT
Committed r69969: <http://trac.webkit.org/changeset/69969>
WebKit Review Bot
Comment 7 2010-10-18 11:06:22 PDT
http://trac.webkit.org/changeset/69969 might have broken Qt Windows 32-bit Release
Note You need to log in before you can comment on or make changes to this bug.