Bug 47822 - Web Inspector: Inspect element tooltip obscures element metrics
Summary: Web Inspector: Inspect element tooltip obscures element metrics
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-18 08:17 PDT by Vernon Thommeret
Modified: 2021-12-21 16:05 PST (History)
14 users (show)

See Also:


Attachments
An image of the inspect element tooltip obscuring element metrics (9.70 KB, image/png)
2010-10-18 08:17 PDT, Vernon Thommeret
no flags Details
[PATCH] Suggested solution (4.31 KB, patch)
2010-11-11 10:37 PST, Alexander Pavlov (apavlov)
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vernon Thommeret 2010-10-18 08:17:20 PDT
Created attachment 71038 [details]
An image of the inspect element tooltip obscuring element metrics

I've attached a picture of what I'm referring to. I'm not sure when the tooltip was introduced, but the image shows an issue that I've run into since it was added — it's not possible to visually see the bottom-margin of an element if either the height of the margin or the width of the element is smaller than the tooltip. I've artificially enlarged element in the second half of the image to show the obscured margin.

I'm not sure that the tooltip is terribly useful (possibly the width and height?) but could possibly the tooltip be made translucent or an give to remove it altogether. I like to use the inspector visually — the whether something is the result of a margin or padding, and it's connection to other elements, but recently this tooltip has just removed that visibility.
Comment 1 Alexander Pavlov (apavlov) 2010-11-11 10:37:17 PST
Created attachment 73623 [details]
[PATCH] Suggested solution

- The tooltip is laid out relative to the margins box rather than the content box.
- The tooltip should obscure the node highlight only if there are no other layout alternatives.
Comment 2 Alexander Pavlov (apavlov) 2010-11-12 09:56:05 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       WebCore/ChangeLog
        M       WebCore/inspector/InspectorController.cpp
Committed r71922
Comment 3 WebKit Review Bot 2010-11-12 12:29:14 PST
http://trac.webkit.org/changeset/71922 might have broken GTK Linux 32-bit Debug
The following tests are not passing:
fast/text/international/plane2.html