Bug 47816 - Remove some unnecessary lines of code from Parser.cpp
Summary: Remove some unnecessary lines of code from Parser.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-18 05:50 PDT by Peter Varga
Modified: 2010-10-18 06:20 PDT (History)
3 users (show)

See Also:


Attachments
proposed patch (1.23 KB, patch)
2010-10-18 05:54 PDT, Peter Varga
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Varga 2010-10-18 05:50:55 PDT
Looks like the parser/Parser.cpp includes two unused headers in JavaScriptCore:
- wtf/HashSet.h
- wtf/Vector.h

The explicit decleration of jscyyparse(void*) function should be removed as well because
we don't use a generated parser any more.
Comment 1 Peter Varga 2010-10-18 05:54:12 PDT
Created attachment 71027 [details]
proposed patch
Comment 2 Andras Becsi 2010-10-18 05:56:56 PDT
Comment on attachment 71027 [details]
proposed patch

LGTM.
Thanks, Peter.
Comment 3 Andreas Kling 2010-10-18 06:02:47 PDT
Comment on attachment 71027 [details]
proposed patch

LGTM, too.
Comment 4 WebKit Commit Bot 2010-10-18 06:20:42 PDT
Comment on attachment 71027 [details]
proposed patch

Clearing flags on attachment: 71027

Committed r69957: <http://trac.webkit.org/changeset/69957>
Comment 5 WebKit Commit Bot 2010-10-18 06:20:47 PDT
All reviewed patches have been landed.  Closing bug.