Bug 47805 - [GTK] Tests LayoutTests/fast/encoding/utf-32* fail when using glib unicode
Summary: [GTK] Tests LayoutTests/fast/encoding/utf-32* fail when using glib unicode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 47990
Blocks:
  Show dependency tree / graph
 
Reported: 2010-10-18 02:38 PDT by Carlos Garcia Campos
Modified: 2010-10-21 04:26 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.53 KB, patch)
2010-10-18 02:46 PDT, Carlos Garcia Campos 		mrobinson: review-
Details | Formatted Diff | Diff
Updated patch for current git master (1.81 KB, patch)
2010-10-21 01:59 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2010-10-18 02:38:46 PDT 
When webkit is built with glib unicode instead of icu tests utf-32-big-endian-bom, utf-32-big-endian-nobom, utf-32-little-endian-bom and utf-32-little-endian-nobom under LayoutTests/fast/encoding fail because TextCodecGtk doesn't register UTF-32 encoding names.
Comment 1 Carlos Garcia Campos 2010-10-18 02:46:22 PDT 
Created attachment 71011 [details]
Patch
Comment 2 WebKit Review Bot 2010-10-18 02:49:36 PDT 
Attachment 71011 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/text/gtk/TextCodecGtk.h:72:  m_codecAliases_UTF_32 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/text/gtk/TextCodecGtk.h:73:  m_codecAliases_UTF_32BE is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/text/gtk/TextCodecGtk.h:74:  m_codecAliases_UTF_32LE is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/text/gtk/TextCodecGtk.cpp:59:  TextCodecGtk::m_codecAliases_UTF_8 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/text/gtk/TextCodecGtk.cpp:60:  TextCodecGtk::m_codecAliases_UTF_32 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/text/gtk/TextCodecGtk.cpp:61:  TextCodecGtk::m_codecAliases_UTF_32BE is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/text/gtk/TextCodecGtk.cpp:62:  TextCodecGtk::m_codecAliases_UTF_32LE is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 7 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Martin Robinson 2010-10-18 14:14:59 PDT 
Comment on attachment 71011 [details]
Patch

Looks good, but please fix all the variable names (e.g. m_codecAliases_UTF_8 --> m_codecAliasesUTF8). Thanks.
Comment 4 Carlos Garcia Campos 2010-10-21 01:59:55 PDT 
Created attachment 71407 [details]
Updated patch for current git master
Comment 5 Martin Robinson 2010-10-21 02:01:29 PDT 
Comment on attachment 71407 [details]
Updated patch for current git master

Much nicer!
Comment 6 WebKit Commit Bot 2010-10-21 04:26:11 PDT 
Comment on attachment 71407 [details]
Updated patch for current git master

Clearing flags on attachment: 71407

Committed r70227: <http://trac.webkit.org/changeset/70227>
Comment 7 WebKit Commit Bot 2010-10-21 04:26:17 PDT 
All reviewed patches have been landed.  Closing bug.