Bug 47797 - Clean up of iframe scrollbar mode code
Summary: Clean up of iframe scrollbar mode code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-17 23:00 PDT by Mike Lawther
Modified: 2010-12-02 07:03 PST (History)
9 users (show)

See Also:

Attachments
Patch (5.26 KB, patch)
2010-10-19 21:10 PDT, Mike Lawther 		no flags Details | Formatted Diff | Diff
Patch (4.76 KB, patch)
2010-11-18 16:20 PST, Mike Lawther 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Lawther 2010-10-17 23:00:07 PDT 
Followup to comments in https://bugs.webkit.org/show_bug.cgi?id=29240#c19 

"Some comments... seems like it would be cleaner to turn off scrollbars early and bail in the helper function rather than doing it at the very end.  That way you're not flipping stuff on and off.

In order to do that, though, you need to pull the setChildNeedsLayout/setNeedsLayout calls (which should never have been put in this code in the first place) out of the helper function and back into the main layout method.

None of this is minus-worthy, though, so could be fixed in a followup."
Comment 1 Mike Lawther 2010-10-19 21:10:10 PDT 
Created attachment 71244 [details]
Patch
Comment 2 Mike Lawther 2010-10-19 21:50:44 PDT 
Hi Hyatt - can you please take a look at this cleanup?
Comment 3 Mike Lawther 2010-11-18 16:20:02 PST 
Created attachment 74314 [details]
Patch
Comment 4 Mike Lawther 2010-11-18 16:21:59 PST 
Made sure patch still applies to current tree.
Comment 5 Dave Hyatt 2010-12-01 15:45:09 PST 
Comment on attachment 74314 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2010-12-02 02:12:45 PST 
Comment on attachment 74314 [details]
Patch

Clearing flags on attachment: 74314

Committed r73117: <http://trac.webkit.org/changeset/73117>
Comment 7 WebKit Commit Bot 2010-12-02 02:12:51 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Review Bot 2010-12-02 02:27:53 PST 
http://trac.webkit.org/changeset/73117 might have broken Qt Linux Release minimal
Comment 9 Csaba Osztrogonác 2010-12-02 03:05:11 PST 
(In reply to comment #8)
> http://trac.webkit.org/changeset/73117 might have broken Qt Linux Release minimal

Buildfix landed in http://trac.webkit.org/changeset/73120