Bug 47789 - check-webkit-style needs to ignore underscores in opcode names and vm_throw
Summary: check-webkit-style needs to ignore underscores in opcode names and vm_throw
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-17 20:36 PDT by Oliver Hunt
Modified: 2010-10-18 04:58 PDT (History)
3 users (show)

See Also:

Attachments
Proposed fix. (4.33 KB, patch)
2010-10-17 22:35 PDT, David Levin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2010-10-17 20:36:14 PDT 
check-webkit-style complains about vm_throw, op_..., and underscores in the various CPU opcode defs.  This makes it very noisy for JSC and will break the cq
Comment 1 David Levin 2010-10-17 22:35:00 PDT 
Created attachment 71000 [details]
Proposed fix.
Comment 2 WebKit Commit Bot 2010-10-18 04:57:56 PDT 
Comment on attachment 71000 [details]
Proposed fix.

Clearing flags on attachment: 71000

Committed r69953: <http://trac.webkit.org/changeset/69953>
Comment 3 WebKit Commit Bot 2010-10-18 04:58:02 PDT 
All reviewed patches have been landed.  Closing bug.