Bug 47786 - Remove explicit passing of user gesture in NavigationScheduler
Summary: Remove explicit passing of user gesture in NavigationScheduler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-17 17:22 PDT by Adam Barth
Modified: 2010-10-17 19:59 PDT (History)
5 users (show)

See Also:


Attachments
Patch (16.64 KB, patch)
2010-10-17 17:25 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-10-17 17:22:49 PDT
Remove explicit passing of user gesture in NavigationScheduler
Comment 1 Adam Barth 2010-10-17 17:25:09 PDT
Created attachment 70988 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2010-10-17 19:29:52 PDT
Comment on attachment 70988 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70988&action=review

Thanks for doing this Adam! This turns our previous rabbit-trail method into a much simpler design.

> WebCore/ChangeLog:8
> +        As requested by Mr. Glazkov, remove more explicit passing of the user

Darn it, I gotta tell my Dad to stop trolling WebKit bug tracker.
Comment 3 WebKit Commit Bot 2010-10-17 19:58:57 PDT
The commit-queue encountered the following flaky tests while processing attachment 70988 [details]:

[u'http/tests/security/xssAuditor/script-tag-with-source-entities.html']

Please file bugs against the tests.  The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2010-10-17 19:59:45 PDT
Comment on attachment 70988 [details]
Patch

Clearing flags on attachment: 70988

Committed r69938: <http://trac.webkit.org/changeset/69938>
Comment 5 WebKit Commit Bot 2010-10-17 19:59:50 PDT
All reviewed patches have been landed.  Closing bug.