Bug 47777 - FrameLoader doesn't need an explicit userGesture parameter
Summary: FrameLoader doesn't need an explicit userGesture parameter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-17 03:03 PDT by Adam Barth
Modified: 2010-10-17 11:10 PDT (History)
4 users (show)

See Also:

Attachments
Patch (20.57 KB, patch)
2010-10-17 03:06 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-10-17 03:03:24 PDT 
FrameLoader doesn't need an explicit userGesture parameter
Comment 1 Adam Barth 2010-10-17 03:06:12 PDT 
Created attachment 70970 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2010-10-17 08:22:46 PDT 
Comment on attachment 70970 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70970&action=review

> WebCore/loader/NavigationScheduler.cpp:@
>  void NavigationScheduler::scheduleLocati

Might as well remove the remaining places where wasUserGesture is passed in and yank that param out.
Comment 3 Dimitri Glazkov (Google) 2010-10-17 08:41:12 PDT 
Comment on attachment 70970 [details]
Patch

I guess that could be done in follow-up patch.
Comment 4 WebKit Commit Bot 2010-10-17 09:03:03 PDT 
Comment on attachment 70970 [details]
Patch

Clearing flags on attachment: 70970

Committed r69924: <http://trac.webkit.org/changeset/69924>
Comment 5 WebKit Commit Bot 2010-10-17 09:03:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Adam Barth 2010-10-17 11:10:02 PDT 
(In reply to comment #2)
> (From update of attachment 70970 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=70970&action=review
> 
> > WebCore/loader/NavigationScheduler.cpp:@
> >  void NavigationScheduler::scheduleLocati
> 
> Might as well remove the remaining places where wasUserGesture is passed in and yank that param out.

Yep.