Bug 47774 – New MathML Baseline for GTK Port

• Status: RESOLVED
• Resolution: FIXED
• Component: MathML

[Alex Milowski]

Created attachment 70966 [details]
New test results

Updated test results based on latest MathML code.

[Daniel Bates]

Comment on attachment 70966 [details]
New test results

View in context: https://bugs.webkit.org/attachment.cgi?id=70966&action=review

There are some noticeable differences between the GTK pixel results (included in this patch) and the Mac pixel results. In particular, the scrollbars present in the screen shot LayoutTests/platform/gtk/mathml/presentation/style-expected.png and small rectangles drawn in place of parentheses in LayoutTests/platform/gtk/mathml/presentation/row-expected.png. We should further investigate these differences

r=me.

> LayoutTests/ChangeLog:5
> +        New baseline for MathML tests for Gtk port.

Nit: From my understanding, GTK is an acronym. So, "Gtk" should be "GTK".

[Daniel Bates]

Comment on attachment 70966 [details]
New test results

Removing from the commit-queue so this can be landed with the commit message fix. Since Alex Milowski does not appear to be a committer I will land this by hand.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 70966 [details]:

[u'http/tests/navigation/image-load-in-unload-handler.html']

Please file bugs against the tests.  The commit-queue is continuing to process your patch.

[Daniel Bates]

Committed r69918: <http://trac.webkit.org/changeset/69918>

[Daniel Bates]

(In reply to comment #3)
> The commit-queue encountered the following flaky tests while processing attachment 70966 [details]:
> 
> [u'http/tests/navigation/image-load-in-unload-handler.html']
> 
> Please file bugs against the tests.  The commit-queue is continuing to process your patch.

At the time I landed this patch by hand the commit queue was idle and there were no patches listed in the "Patches in queue" section of <http://queues.webkit.org/queue-status/commit-queue>. I hope that the commit queue saw the cq- flag and stopped processing the patch.

[Alex Milowski]

(In reply to comment #1)
> (From update of attachment 70966 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=70966&action=review
> 
> There are some noticeable differences between the GTK pixel results (included in this patch) and the Mac pixel results. In particular, the scrollbars present in the screen shot LayoutTests/platform/gtk/mathml/presentation/style-expected.png and small rectangles drawn in place of parentheses in LayoutTests/platform/gtk/mathml/presentation/row-expected.png. We should further investigate these differences
> 


Yes.  There are a lot of issues that need to be address on the GTK version.  I'll be looking into these a lot more now that I have a stable development environment for GTK.

The small rectangles will go away once we start using the STIX fonts.