Bug 47766 - Enrich /fast/dom/nodesFromRect-basic.html test
Summary: Enrich /fast/dom/nodesFromRect-basic.html test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Antonio Gomes
URL:
Keywords:
Depends on:
Blocks: 46336
  Show dependency treegraph
 
Reported: 2010-10-16 05:49 PDT by Antonio Gomes
Modified: 2010-10-17 21:32 PDT (History)
4 users (show)

See Also:


Attachments
(committed r69939, r=smfr) patch v1. (7.99 KB, patch)
2010-10-17 20:46 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2010-10-16 05:49:33 PDT
In the test we are doing stuff like:

check(53, 71, 0, 0, 0, 0, [e.body]);
check(53, 71, 0, 10, 0, 10, [e.p3, e.body]);
check(53, 71, 10, 0, 10, 0, [e.d1, e.h1, e.body]);
check(53, 71, 10, 10, 10, 10, [e.p3, e.d1, e.h1, e.body]);

Now that we support specifying the four direction to expansion separately, we can enrich these tests. It would turn to:

check(53, 71, 0, 0, 0, 0, [e.body]);
check(53, 71, 10, 0, 0, 0, [result]);
check(53, 71, 0, 10, 0, 0, [result]);
check(53, 71, 0, 0, 10, 0, [result]);
check(53, 71, 0, 0, 0, 10, [result]);
check(53, 71, 10, 10, 0, 0, [result]);
check(53, 71, 10, 10, 0, 10, [result]);
etc...

Combinations are up to us.
Comment 1 Antonio Gomes 2010-10-17 20:46:01 PDT
Created attachment 70991 [details]
(committed r69939, r=smfr) patch v1.

Patch makes fast/dom/nodesFromRect-basic.html test more precise: instead of calling nodesFromRect always with equal vertical (up and down) and horizontal (right and left) padding values, it are now tests it by passing different padding values on the various directions.
Comment 2 Antonio Gomes 2010-10-17 21:32:08 PDT
Comment on attachment 70991 [details]
(committed r69939, r=smfr) patch v1.

Clearing flags on attachment: 70991

Committed r69939: <http://trac.webkit.org/changeset/69939>