Add missing namespaces for currentTimeMS() of CurrentTime.h and parseDateFromNullTerminatedCharacters() of DateMath.h.
Created attachment 70935 [details] Add using clauses
Attachment 70935 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/ChangeLog:5: Line contains tab character. [whitespace/tab] [5] JavaScriptCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 70937 [details] Fixed style error.
Comment on attachment 70937 [details] Fixed style error. View in context: https://bugs.webkit.org/attachment.cgi?id=70937&action=review Looks fine otherwise. > JavaScriptCore/ChangeLog:7 > + Please add the bug URL in the ChangeLog entry.
Created attachment 70963 [details] Add using clauses Add bug url.
Comment on attachment 70963 [details] Add using clauses C++ has "using declaration", and "using directive", but not "using clause". The ones you're adding are using declarations. Please correct the ChangeLog.
Created attachment 70968 [details] Add using declarations
Comment on attachment 70968 [details] Add using declarations "clause" is changed to "declaration".
Comment on attachment 70968 [details] Add using declarations Thank you! Now that these have using declarations for these, we can remove namespace prefixes at call sites, as well as perhaps "using WTF;" directives in some files.
thank you.
Comment on attachment 70968 [details] Add using declarations Clearing flags on attachment: 70968 Committed r69920: <http://trac.webkit.org/changeset/69920>
All reviewed patches have been landed. Closing bug.