RESOLVED FIXED 47758
Add using declarations for currentTimeMS() and parseDateFromNullTerminatedCharacters() 
https://bugs.webkit.org/show_bug.cgi?id=47758
Summary Add using declarations for currentTimeMS() and parseDateFromNullTerminatedCha...
Kim, kyusun
Reported 2010-10-15 17:50:50 PDT
Add missing namespaces for currentTimeMS() of CurrentTime.h and parseDateFromNullTerminatedCharacters() of DateMath.h.
Attachments
Add using clauses (1.29 KB, patch)
2010-10-15 18:06 PDT, Kim, kyusun 		no flags
DetailsFormatted DiffDiff
Fixed style error. (1.30 KB, patch)
2010-10-15 18:13 PDT, Kim, kyusun 		kling: review-
kling: commit-queue-
DetailsFormatted DiffDiff
Add using clauses (1.34 KB, patch)
2010-10-16 13:50 PDT, Kim, kyusun 		ap: commit-queue-
DetailsFormatted DiffDiff
Add using declarations (1.35 KB, patch)
2010-10-16 17:42 PDT, Kim, kyusun 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Kim, kyusun
Comment 1 2010-10-15 18:06:07 PDT
Created attachment 70935 [details] Add using clauses
WebKit Review Bot
Comment 2 2010-10-15 18:07:32 PDT
Attachment 70935 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/ChangeLog:5: Line contains tab character. [whitespace/tab] [5] JavaScriptCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kim, kyusun
Comment 3 2010-10-15 18:13:14 PDT
Created attachment 70937 [details] Fixed style error.
Andreas Kling
Comment 4 2010-10-16 03:39:00 PDT
Comment on attachment 70937 [details] Fixed style error. View in context: https://bugs.webkit.org/attachment.cgi?id=70937&action=review Looks fine otherwise. > JavaScriptCore/ChangeLog:7 > + Please add the bug URL in the ChangeLog entry.
Kim, kyusun
Comment 5 2010-10-16 13:50:26 PDT
Created attachment 70963 [details] Add using clauses Add bug url.
Alexey Proskuryakov
Comment 6 2010-10-16 17:05:06 PDT
Comment on attachment 70963 [details] Add using clauses C++ has "using declaration", and "using directive", but not "using clause". The ones you're adding are using declarations. Please correct the ChangeLog.
Kim, kyusun
Comment 7 2010-10-16 17:42:51 PDT
Created attachment 70968 [details] Add using declarations
Kim, kyusun
Comment 8 2010-10-16 17:44:15 PDT
Comment on attachment 70968 [details] Add using declarations "clause" is changed to "declaration".
Alexey Proskuryakov
Comment 9 2010-10-16 21:09:48 PDT
Comment on attachment 70968 [details] Add using declarations Thank you! Now that these have using declarations for these, we can remove namespace prefixes at call sites, as well as perhaps "using WTF;" directives in some files.
Kim, kyusun
Comment 10 2010-10-16 21:15:56 PDT
thank you.
WebKit Commit Bot
Comment 11 2010-10-16 21:43:13 PDT
Comment on attachment 70968 [details] Add using declarations Clearing flags on attachment: 70968 Committed r69920: <http://trac.webkit.org/changeset/69920>
WebKit Commit Bot
Comment 12 2010-10-16 21:43:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.