Bug 47734 – Move MarkupAccumulator from markup.cpp to its own file

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

Move MarkupAccumulator from markup.cpp to its own file

[Adam Barth]

Created attachment 70890 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 70890 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70890&action=review

If you're just moving code, rs=me.

> WebCore/editing/EditingAllInOne.cpp:51
> +#include <MarkupAccumulator.cpp>

Huh?  Why are these all <>.  That makes no sense to me.  They shoudl be "".  Obviously another patch.

[Ryosuke Niwa]

View in context: https://bugs.webkit.org/attachment.cgi?id=70890&action=review

Thanks for doing this!

> WebCore/WebCore.xcodeproj/project.pbxproj:-21138
> -			developmentRegion = English;

You should revert this change.

> WebCore/editing/MarkupAccumulator.cpp:2
> + * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.

Maybe add Google as well since we've done considerable work cleaning the code up?

> WebCore/editing/markup.h:61
> +
> +    // FIXME: Should this be better encapulated somewhere?
> +    bool elementCannotHaveEndTag(const Node*);

I think you can move this into MarkupAccumulator once you make the serializeNodes a member function of MarkupAccumulator.

[Adam Barth]

> > WebCore/editing/MarkupAccumulator.cpp:2
> > + * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
> 
> Maybe add Google as well since we've done considerable work cleaning the code up?

I didn't change the copyright since this patch doesn't do anything that impacts the copyright on the file.  Feel free to change it in a future patch.

[Adam Barth]

Committed r69880: <http://trac.webkit.org/changeset/69880>

[Ryosuke Niwa]

Comment on attachment 70890 [details]
Patch

Cleared review & cq flags so that this patch won't appear on the review queue.