Bug 47734 - Move MarkupAccumulator from markup.cpp to its own file
Summary: Move MarkupAccumulator from markup.cpp to its own file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-15 12:54 PDT by Adam Barth
Modified: 2011-02-06 22:14 PST (History)
3 users (show)

See Also:

Attachments
Patch (48.49 KB, patch)
2010-10-15 13:06 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-10-15 12:54:59 PDT 
Move MarkupAccumulator from markup.cpp to its own file
Comment 1 Adam Barth 2010-10-15 13:06:57 PDT 
Created attachment 70890 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-10-15 13:48:52 PDT 
Comment on attachment 70890 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70890&action=review

If you're just moving code, rs=me.

> WebCore/editing/EditingAllInOne.cpp:51
> +#include <MarkupAccumulator.cpp>

Huh?  Why are these all <>.  That makes no sense to me.  They shoudl be "".  Obviously another patch.
Comment 3 Ryosuke Niwa 2010-10-15 13:49:45 PDT 
View in context: https://bugs.webkit.org/attachment.cgi?id=70890&action=review

Thanks for doing this!

> WebCore/WebCore.xcodeproj/project.pbxproj:-21138
> -			developmentRegion = English;

You should revert this change.

> WebCore/editing/MarkupAccumulator.cpp:2
> + * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.

Maybe add Google as well since we've done considerable work cleaning the code up?

> WebCore/editing/markup.h:61
> +
> +    // FIXME: Should this be better encapulated somewhere?
> +    bool elementCannotHaveEndTag(const Node*);

I think you can move this into MarkupAccumulator once you make the serializeNodes a member function of MarkupAccumulator.
Comment 4 Adam Barth 2010-10-15 14:34:38 PDT 
> > WebCore/editing/MarkupAccumulator.cpp:2
> > + * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
> 
> Maybe add Google as well since we've done considerable work cleaning the code up?

I didn't change the copyright since this patch doesn't do anything that impacts the copyright on the file.  Feel free to change it in a future patch.
Comment 5 Adam Barth 2010-10-15 14:35:06 PDT 
Committed r69880: <http://trac.webkit.org/changeset/69880>
Comment 6 Ryosuke Niwa 2011-02-06 22:14:39 PST 
Comment on attachment 70890 [details]
Patch

Cleared review & cq flags so that this patch won't appear on the review queue.