I see this when building the Soup cache code: ../../WebCore/platform/network/soup/cache/webkit/soup-cache.c: In function ‘webkit_soup_cache_entry_set_freshness’: ../../WebCore/platform/network/soup/cache/webkit/soup-cache.c:300: warning: cast from pointer to integer of different size ../../WebCore/platform/network/soup/cache/webkit/soup-cache.c: In function ‘close_ready_cb’: ../../WebCore/platform/network/soup/cache/webkit/soup-cache.c:512: warning: comparison between signed and unsigned integer expressions
Created attachment 71148 [details] proposed patch
Comment on attachment 71148 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=71148&action=review > WebCore/platform/network/soup/cache/webkit/soup-cache.c:302 > The original code would NOT revalidate if the 'must-revalidate' is not present. Your patch changes that so that it WILL revalidate if the key is not there. I don't think that's right?
Created attachment 71155 [details] updated patch
Comment on attachment 71155 [details] updated patch Awesome.
Committed r70056: <http://trac.webkit.org/changeset/70056>