Bug 47733 - [GTK] Soup cache code still has some warnings
Summary: [GTK] Soup cache code still has some warnings
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2010-10-15 12:54 PDT by Martin Robinson
Modified: 2010-10-19 07:39 PDT (History)
3 users (show)

See Also:

proposed patch (2.27 KB, patch)
2010-10-19 02:48 PDT, Philippe Normand
xan.lopez: review-
Details | Formatted Diff | Diff
updated patch (2.21 KB, patch)
2010-10-19 05:05 PDT, Philippe Normand
xan.lopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-10-15 12:54:19 PDT
I see this when building the Soup cache code:

../../WebCore/platform/network/soup/cache/webkit/soup-cache.c: In function ‘webkit_soup_cache_entry_set_freshness’:
../../WebCore/platform/network/soup/cache/webkit/soup-cache.c:300: warning: cast from pointer to integer of different size
../../WebCore/platform/network/soup/cache/webkit/soup-cache.c: In function ‘close_ready_cb’:
../../WebCore/platform/network/soup/cache/webkit/soup-cache.c:512: warning: comparison between signed and unsigned integer expressions
Comment 1 Philippe Normand 2010-10-19 02:48:10 PDT
Created attachment 71148 [details]
proposed patch
Comment 2 Xan Lopez 2010-10-19 03:28:31 PDT
Comment on attachment 71148 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71148&action=review

> WebCore/platform/network/soup/cache/webkit/soup-cache.c:302

The original code would NOT revalidate if the 'must-revalidate' is not present. Your patch changes that so that it WILL revalidate if the key is not there. I don't think that's right?
Comment 3 Philippe Normand 2010-10-19 05:05:07 PDT
Created attachment 71155 [details]
updated patch
Comment 4 Xan Lopez 2010-10-19 07:30:17 PDT
Comment on attachment 71155 [details]
updated patch

Comment 5 Philippe Normand 2010-10-19 07:39:28 PDT
Committed r70056: <http://trac.webkit.org/changeset/70056>