All function members in TextRunWorker are defined as inlined.
Most of them should not.
Created attachment 70888 [details]
Comment on attachment 70888 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=70888&action=review
Please consider addressing my comments on landing.
> + TextRunWalker(const TextRun& run, unsigned startingX, const Font* font);
Remove param names that add no information: "run", "font".
> + bool isWordBreak(unsigned i, bool isRTL);
What is "i? In its current form, I'd remove it, but I have no idea what that param is. Should it be called index?
> + void setPadding(int padding);
No need for "padding". (Since the method name is setPadding and it only takes one parameter.)
> + void setBackwardsIteration(bool isBackwards);
Remove param name.
Committed r69972: <http://trac.webkit.org/changeset/69972>
http://trac.webkit.org/changeset/69972 might have broken Qt Windows 32-bit Release