Bug 47732 – [chromium] FontLinux.cpp cleanup (move most methods in TextRunWorker from inlined)

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Xiaomei Ji]

All function members in TextRunWorker are defined as inlined.
Most of them should not.

[Xiaomei Ji]

Created attachment 70888 [details]
patch

[David Levin]

Comment on attachment 70888 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70888&action=review

Please consider addressing my comments on landing.

> WebCore/platform/graphics/chromium/FontLinux.cpp:164
> +    TextRunWalker(const TextRun& run, unsigned startingX, const Font* font);

Remove param names that add no information: "run", "font".

> WebCore/platform/graphics/chromium/FontLinux.cpp:167
> +    bool isWordBreak(unsigned i, bool isRTL);

What is "i? In its current form, I'd remove it, but I have no idea what that param is. Should it be called index?

> WebCore/platform/graphics/chromium/FontLinux.cpp:170
> +    void setPadding(int padding);

No need for "padding". (Since the method name is setPadding and it only takes one parameter.)

> WebCore/platform/graphics/chromium/FontLinux.cpp:172
> +    void setBackwardsIteration(bool isBackwards);

Remove param name.

[Xiaomei Ji]

Committed r69972: <http://trac.webkit.org/changeset/69972>

[WebKit Review Bot]

http://trac.webkit.org/changeset/69972 might have broken Qt Windows 32-bit Release