Bug 47714 – Replace some String::format() usages by StringConcatenate in WebKit

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Nikolas Zimmermann]

As done in patch 47664 for WebCore, do the same in WebKit.

[Nikolas Zimmermann]

Created attachment 70839 [details]
Patch

[WebKit Review Bot]

Attachment 70839 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/src/BackForwardListClientImpl.cpp:106:  url_string is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Nikolas Zimmermann]

(In reply to comment #2)
> Attachment 70839 [details] did not pass style-queue:
> 
> Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
> WebKit/chromium/src/BackForwardListClientImpl.cpp:106:  url_string is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
> Total errors found: 1 in 14 files

I'm not planing to rename existing variables in chromium code, I think it's safe to ignore this error.

[Nikolas Zimmermann]

Created attachment 70842 [details]
Patch v2

Fix a typo s/char/UChar/ in the new StringTypeAdapter. Also changed my mind, renamed url_string to urlString, to have a green style bot result.

[WebKit Review Bot]

Attachment 70839 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/4462042

[Nikolas Zimmermann]

Created attachment 70845 [details]
Patch v3

Add explicit cast from WebString -> String, attempting to fix the chromium build.

[WebKit Review Bot]

Attachment 70845 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/4455056

[Nikolas Zimmermann]

Created attachment 70850 [details]
Patch v4

Arrgl, missed another WebString -> String conversion in WebPageSerializer. Fix and optimize it even further.

[Nikolas Zimmermann]

Created attachment 70854 [details]
Patch v5

*sigh* Forgot to include JavaScriptCore changes. Added StringTypeAdapter<UChar> to avoid having to convert UChars, we can directly append them.

[Dirk Schulze]

Comment on attachment 70854 [details]
Patch v5

View in context: https://bugs.webkit.org/attachment.cgi?id=70854&action=review

LGTM. r=me

> WebKit/chromium/src/BackForwardListClientImpl.cpp:107
> +    m_pendingHistoryItem = HistoryItem::create(urlString, String(), 0.0);

Please use 0

[Nikolas Zimmermann]

Committed r69850: <http://trac.webkit.org/changeset/69850>