Bug 47707 - Update our clone of Philip Taylor's canvas test suite
Summary: Update our clone of Philip Taylor's canvas test suite
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-14 18:34 PDT by Andreas Kling
Modified: 2010-11-07 05:50 PST (History)
2 users (show)

See Also:


Attachments
Proposed patch (1.86 MB, patch)
2010-10-14 18:38 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff
Proposed patch v2 (1.76 MB, patch)
2010-10-18 03:30 PDT, Andreas Kling
jamesr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-10-14 18:34:21 PDT
Several improvements and additions have been made to the tests upstream since we imported them into LayoutTests/canvas/philip/
Comment 1 Andreas Kling 2010-10-14 18:38:57 PDT
Created attachment 70817 [details]
Proposed patch

A modest first stab at this.
Comment 2 James Robinson 2010-10-14 19:06:19 PDT
Few general notes:

*) please edit down the LayoutTests/ChangeLog file to just list canvas/philip/ and not all the files individually. it doesn't really help to have a 1000+ line changelog entry
*) can we record the exact revision of the test suite we have checked in somewhere? maybe in a README or the like?
Comment 3 Andreas Kling 2010-10-14 19:09:37 PDT
Comment on attachment 70817 [details]
Proposed patch

Removing r?, will continue on this tomorrow..
Comment 4 Andreas Kling 2010-10-18 03:30:40 PDT
Created attachment 71015 [details]
Proposed patch v2

Trimmed ChangeLog, added LayoutTests/canvas/philip/README with URL to upstream rev.
Also included images this time (yay svn-create-patch!)
Comment 5 James Robinson 2010-10-28 14:43:15 PDT
Comment on attachment 71015 [details]
Proposed patch v2

Whoops!  I totally forgot about this.  Looks great.
Comment 6 Matthew Delaney 2010-10-28 15:03:56 PDT
Andreas, awesome!

Could we keep these failing tests off the skipped list and just update the expectation files for the specific platforms (at least in the mac world, i.e. mac-snowleopard). I just landed a patch earlier today to unskip all the tests that we want to track the progressions/regressions of.

If it's a hassle for you to check on the mac platforms, you could just leave them skipped in this patch and make a follow up bug to unskip the ones that we want to track. Thanks!
Comment 7 Andreas Kling 2010-11-07 05:50:06 PST
Committed r71481: <http://trac.webkit.org/changeset/71481>