Bug 47694 – [CMAKE] additional arguments was missed in GENERATE_DOM_NAMES

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Ryuan Choi]

crash while loading http://www.samsung.com/us.
The reason looks that EFL port doesn't define STORE_FONT_CUSTOM_PLATFORM_DATA in CachedFont.cpp like other ports.

[Ryuan Choi]

I found simple page which have same crash : https://bug-38758-attachments.webkit.org/attachment.cgi?id=55715

[Ryuan Choi]

Created attachment 70818 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 70818 [details]
Patch

Ok, it avoid a crash, but the question is, does it make sense? Please state that in the ChangeLog.

[Ryuan Choi]

(In reply to comment #3)
> (From update of attachment 70818 [details])
> Ok, it avoid a crash, but the question is, does it make sense? Please state that in the ChangeLog.

ah... you're right. It can't fix the real problem. It can make just passed above two cases.

To find real solution, I need more time to investigate it.

Thank you for your reviewing.

[Ryuan Choi]

Created attachment 71037 [details]
Patch

[Ryuan Choi]

(In reply to comment #5)
> Created an attachment (id=71037) [details]
> Patch

I found that WebKitMacros.cmake missed _additionArguments.
So some code was not generated.
(especially SVGFontFaceElement::create for crashes I reported).

[Leandro Pereira]

Comment on attachment 71037 [details]
Patch

LGTM.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 71037 [details]:



Please file bugs against the tests.  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 71037 [details]
Patch

Rejecting patch 71037 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--ignore-builders', '--quiet', '--non-interactive', '--parent-command=commit-queue', 71037]" exit_code: 1
Last 500 characters of output:
t.org/attachment.cgi?id=71037&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=47694&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Updating working directory
Processing patch 71037 from bug 47694.
NOBODY (OOPS!) found in /Projects/CommitQueue/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /Projects/CommitQueue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/4496046

[Ryuan Choi]

Created attachment 71241 [details]
Patch

[Ryuan Choi]

(In reply to comment #10)
> Created an attachment (id=71241) [details]
> Patch

Although I am not sure if this don't need r+, I removed review flag.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 71241 [details]:

http/tests/websocket/tests/handshake-challenge-randomness.html

Please file bugs against the tests.  The author(s) of the test(s) have been CCed on this bug.  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 71241 [details]
Patch

Clearing flags on attachment: 71241

Committed r70120: <http://trac.webkit.org/changeset/70120>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.