Bug 47671 - Pressing the Alt key when MiniBrowser's WKView is focused doesn't send focus to the menu bar
Summary: Pressing the Alt key when MiniBrowser's WKView is focused doesn't send focus ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Windows XP
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-14 08:29 PDT by Adam Roben (:aroben)
Modified: 2010-10-14 12:29 PDT (History)
4 users (show)

See Also:

Attachments
Patch (23.41 KB, patch)
2010-10-14 08:31 PDT, Adam Roben (:aroben) 		no flags Details | Formatted Diff | Diff
Call ::DefWindowProcW for unhandled key events (23.42 KB, patch)
2010-10-14 08:46 PDT, Adam Roben (:aroben) 		sfalken: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-10-14 08:29:54 PDT 
Pressing the Alt key when MiniBrowser's WKView is focused doesn't send focus to the menu bar
Comment 1 Adam Roben (:aroben) 2010-10-14 08:31:25 PDT 
Created attachment 70739 [details]
Patch
Comment 2 WebKit Review Bot 2010-10-14 08:38:31 PDT 
Attachment 70739 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2010-10-14 08:43:39 PDT 
Attachment 70739 [details] did not build on qt:
Build output: http://queues.webkit.org/results/4381030
Comment 4 Adam Roben (:aroben) 2010-10-14 08:46:43 PDT 
Created attachment 70742 [details]
Call ::DefWindowProcW for unhandled key events
Comment 5 WebKit Review Bot 2010-10-14 08:52:31 PDT 
Attachment 70742 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Adam Roben (:aroben) 2010-10-14 12:29:43 PDT 
Committed r69788: <http://trac.webkit.org/changeset/69788>