Bug 47666 - [GTK] Failing test LayoutTests/editing/undo/orphaned-selection-crash-bug32823-2.html
Summary: [GTK] Failing test LayoutTests/editing/undo/orphaned-selection-crash-bug32823...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-14 05:27 PDT by Sergio Villar Senin
Modified: 2010-10-15 00:22 PDT (History)
2 users (show)

See Also:


Attachments
Fix for the failing test (1.92 KB, patch)
2010-10-14 05:32 PDT, Sergio Villar Senin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2010-10-14 05:27:52 PDT
The actual issue is most likely https://bugs.webkit.org/show_bug.cgi?id=47661.

We have now a more strict decoding of base64 data with the recent land of the soupURILoader stuff. That's the reason why this test started to fail.
Comment 1 Sergio Villar Senin 2010-10-14 05:32:14 PDT
Created attachment 70730 [details]
Fix for the failing test

Reverted to old behaviour
Comment 2 Xan Lopez 2010-10-14 05:35:59 PDT
Comment on attachment 70730 [details]
Fix for the failing test

r=me
Comment 3 WebKit Commit Bot 2010-10-14 10:14:08 PDT
Comment on attachment 70730 [details]
Fix for the failing test

Clearing flags on attachment: 70730

Committed r69775: <http://trac.webkit.org/changeset/69775>
Comment 4 WebKit Commit Bot 2010-10-14 10:14:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2010-10-14 12:39:49 PDT
Note that Safari (or more precisely, CFNetwork) is strict in this respect - "data:image/png;base64,iVBORw0KGrkJggg==" fails to load, while "data:image/png;base64,iVBORw0KGrkJggg=" loads fine (but then fails to render, since the data itself is of course broken).

This matches Firefox.
Comment 6 Martin Robinson 2010-10-14 14:45:18 PDT
So perhaps instead of loading the URL, we just need to  fail in a better way?
Comment 7 Sergio Villar Senin 2010-10-15 00:22:29 PDT
(In reply to comment #6)
> So perhaps instead of loading the URL, we just need to  fail in a better way?

Yeah. We reverted the change in order to mimic the old behaviour but I think it'd be better to fail in a better way