Bug 47660 - SVGFEConvolveMatrixElement doesn't support dynamic invalidation
Summary: SVGFEConvolveMatrixElement doesn't support dynamic invalidation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Renata Hodovan
URL:
Keywords:
Depends on:
Blocks: 45453
  Show dependency tree / graph
 
Reported: 2010-10-14 01:54 PDT by Renata Hodovan
Modified: 2010-11-11 05:13 PST (History)
4 users (show)

See Also:

Attachments
Patch for feConvolveMatrix DOM attributes (1.47 MB, patch)
2010-10-14 03:50 PDT, Renata Hodovan 		kling: review-
Details | Formatted Diff | Diff
Patch for feConvolveMatrix DOM attributes (1.47 MB, patch)
2010-10-14 05:30 PDT, Renata Hodovan 		no flags Details | Formatted Diff | Diff
Patch (1.49 MB, patch)
2010-11-05 07:04 PDT, Renata Hodovan 		zimmermann: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Renata Hodovan 2010-10-14 01:54:27 PDT 
SVGFEConvolveMatrixElement doesn't support dynamic invalidation
Comment 1 Renata Hodovan 2010-10-14 03:50:48 PDT 
Created attachment 70723 [details]
Patch for feConvolveMatrix DOM attributes
Comment 2 Andreas Kling 2010-10-14 04:06:12 PDT 
Comment on attachment 70723 [details]
Patch for feConvolveMatrix DOM attributes

View in context: https://bugs.webkit.org/attachment.cgi?id=70723&action=review

> WebCore/svg/SVGFEConvolveMatrixElement.idl:54
> +        void setKernelUnitLength(in float kernelUnitLengthX, in float kernelUnitLengthY);
> +        void setOrder(in unsigned long orderX, in unsigned long orderY);

Why are you adding these, are they in the specification?
Regardless, they're not covered by any layout tests. This needs to be fixed.
Comment 3 Renata Hodovan 2010-10-14 05:30:27 PDT 
Created attachment 70729 [details]
Patch for feConvolveMatrix DOM attributes
Comment 4 Renata Hodovan 2010-10-14 05:31:26 PDT 
(In reply to comment #2)
> (From update of attachment 70723 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=70723&action=review
> 
> > WebCore/svg/SVGFEConvolveMatrixElement.idl:54
> > +        void setKernelUnitLength(in float kernelUnitLengthX, in float kernelUnitLengthY);
> > +        void setOrder(in unsigned long orderX, in unsigned long orderY);
> 
> Why are you adding these, are they in the specification?
> Regardless, they're not covered by any layout tests. This needs to be fixed.

It's done. You were right, these setters are really not part of spec.
Comment 5 Andreas Kling 2010-10-14 05:36:33 PDT 
Comment on attachment 70729 [details]
Patch for feConvolveMatrix DOM attributes

Looks great, r=me
Comment 6 WebKit Commit Bot 2010-10-14 10:13:09 PDT 
Comment on attachment 70729 [details]
Patch for feConvolveMatrix DOM attributes

Clearing flags on attachment: 70729

Committed r69774: <http://trac.webkit.org/changeset/69774>
Comment 7 WebKit Commit Bot 2010-10-14 10:13:19 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Andreas Kling 2010-11-05 07:01:30 PDT 
Reopening
Comment 9 Renata Hodovan 2010-11-05 07:04:00 PDT 
Created attachment 73061 [details]
Patch
Comment 10 Nikolas Zimmermann 2010-11-05 23:11:07 PDT 
Comment on attachment 73061 [details]
Patch

Great job, Reni. r=me. Looking forward to your first real commit :-)
Comment 11 Renata Hodovan 2010-11-11 05:13:39 PST 
Landed in 71508: http://trac.webkit.org/changeset/71508
Closing bug.