SVGFEConvolveMatrixElement doesn't support dynamic invalidation
Created attachment 70723 [details] Patch for feConvolveMatrix DOM attributes
Comment on attachment 70723 [details] Patch for feConvolveMatrix DOM attributes View in context: https://bugs.webkit.org/attachment.cgi?id=70723&action=review > WebCore/svg/SVGFEConvolveMatrixElement.idl:54 > + void setKernelUnitLength(in float kernelUnitLengthX, in float kernelUnitLengthY); > + void setOrder(in unsigned long orderX, in unsigned long orderY); Why are you adding these, are they in the specification? Regardless, they're not covered by any layout tests. This needs to be fixed.
Created attachment 70729 [details] Patch for feConvolveMatrix DOM attributes
(In reply to comment #2) > (From update of attachment 70723 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=70723&action=review > > > WebCore/svg/SVGFEConvolveMatrixElement.idl:54 > > + void setKernelUnitLength(in float kernelUnitLengthX, in float kernelUnitLengthY); > > + void setOrder(in unsigned long orderX, in unsigned long orderY); > > Why are you adding these, are they in the specification? > Regardless, they're not covered by any layout tests. This needs to be fixed. It's done. You were right, these setters are really not part of spec.
Comment on attachment 70729 [details] Patch for feConvolveMatrix DOM attributes Looks great, r=me
Comment on attachment 70729 [details] Patch for feConvolveMatrix DOM attributes Clearing flags on attachment: 70729 Committed r69774: <http://trac.webkit.org/changeset/69774>
All reviewed patches have been landed. Closing bug.
Reopening
Created attachment 73061 [details] Patch
Comment on attachment 73061 [details] Patch Great job, Reni. r=me. Looking forward to your first real commit :-)
Landed in 71508: http://trac.webkit.org/changeset/71508 Closing bug.