Bug 47656 – [GTK] Needs fixing mistyped comments in the API documentation

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Joone Hur]

There are mistyped comments in webkitwebsettings.cpp and webkitwebwindowfeatures.cpp

[Joone Hur]

Created attachment 70717 [details]
Proposed Patch1

[Gustavo Noronha (kov)]

Comment on attachment 70717 [details]
Proposed Patch1

View in context: https://bugs.webkit.org/attachment.cgi?id=70717&action=review

> WebKit/gtk/webkit/webkitwebsettings.cpp:49
> - * the to be used text encoding, color, font sizes, printing mode,
> + * the behaviour to be used text encoding, color, font sizes, printing mode,

This change looks wrong. The grammar is a bit weird the way it is now, but not sure it's wrong - would be good to have input from a native English speaker =D

[Xan Lopez]

(In reply to comment #2)
> This change looks wrong. The grammar is a bit weird the way it is now, but not sure it's wrong - would be good to have input from a native English speaker =D

Looks wrong indeed. I'd just do s/the to be used/its/ in the original text. But I agree with having Martin just put there something ;)

[Joone Hur]

(In reply to comment #2)
> (From update of attachment 70717 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=70717&action=review
> 
> > WebKit/gtk/webkit/webkitwebsettings.cpp:49
> > - * the to be used text encoding, color, font sizes, printing mode,
> > + * the behaviour to be used text encoding, color, font sizes, printing mode,
> 
> This change looks wrong. The grammar is a bit weird the way it is now, but not sure it's wrong - would be good to have input from a native English speaker =D

How about this?

#WebKitWebSettings can be applied to a #WebKitWebView to control the behaviour to be used, text encoding, color, font sizes, printing mode, script support, loading of images and various other things.

[Martin Robinson]

Here's my suggestion:

(old)
WebKitWebSettings can be applied to a WebKitWebView to control the to be used text encoding, color, font sizes, printing mode, script support, loading of images and various other things.

(new)
WebKitWebSettings can be applied to a WebKitWebView to control text encoding, color, font sizes, printing mode, script support, loading of images and various other things. After creation, a WebKitWebSettings object contains default settings.

[Joone Hur]

Created attachment 70822 [details]
Proposed Patch2

Thanks, Martin. I applied your suggestion to the patch.

[Martin Robinson]

Thanks!

[WebKit Commit Bot]

Comment on attachment 70822 [details]
Proposed Patch2

Clearing flags on attachment: 70822

Committed r70036: <http://trac.webkit.org/changeset/70036>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.