Bug 47654 – Chromium port can't run JavaScriptCore tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

Chromium port can't run JavaScriptCore tests

[Adam Barth]

Created attachment 70711 [details]
Patch

[Adam Barth]

Committed r69738: <http://trac.webkit.org/changeset/69738>

[Eric Seidel (no email)]

Comment on attachment 70711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70711&action=review

Would be better to rename it to "JavaScript tests" and just return "echo 'nothing to do'" for Chromium.  Eventually run-javascriptcore-tests could be made to work for v8 if we desired.

> WebKitTools/Scripts/webkitpy/tool/steps/runtests.py:55
> +        javascriptcore_tests_command = self.port().run_javascriptcore_tests_command()
> +        if javascriptcore_tests_command:
> +            log("Running JavaScriptCore tests")
> +            self._tool.executive.run_and_throw_if_fail(javascriptcore_tests_command, quiet=True)

Very lame.  So much extra code for this one stupid branch.

[Eric Seidel (no email)]

That was kinda dickish.

[Adam Barth]

:(

[Adam Barth]

Each of these patches blocks progress on the bot.  I'll try to patch these in manually instead of using the svn repo as the communication channel between my development machine and the bot.

[Eric Seidel (no email)]

I think it's rude to ask for review and then ignore the comments (especially with an in-person cackle).

This isn't really a patch to land unreviewed anyway.  You made the code uglier/less-hackable.

I've said my piece.  This is not the end of the world.

[Alexey Proskuryakov]

Comment on attachment 70711 [details]
Patch

Clearing r? flag in a resolved bug.

Quoting Maciej, "please, ladies & gentlemen, let's try to remain courteous in these discussions".

[Adam Barth]

I'll revert the patch and we can try again.