Bug 47650 - Make --port a global option and pass the port information to the commit-queue subprocess
Summary: Make --port a global option and pass the port information to the commit-queue...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-13 20:54 PDT by Adam Barth
Modified: 2010-10-13 22:05 PDT (History)
1 user (show)

See Also:

Attachments
Patch (12.12 KB, patch)
2010-10-13 20:59 PDT, Adam Barth 		eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-10-13 20:54:08 PDT 
Make --port a global option and pass the port information to the commit-queue subprocess
Comment 1 Adam Barth 2010-10-13 20:59:53 PDT 
Created attachment 70708 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-10-13 21:48:18 PDT 
Comment on attachment 70708 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70708&action=review

Relatively disgusting.  BUt not all your fault.  Please fix the above nits.

> WebKitTools/Scripts/webkitpy/tool/commands/queues.py:130
> -        self.options = options  # FIXME: This code is wrong.  Command.options is a list, this assumes an Options element!
> +        self._options = options

Please dont' remove this fixme, this code is still WRONG.

> WebKitTools/Scripts/webkitpy/tool/commands/queues_unittest.py:87
> +        queue._options = Mock()
> +        queue._options.iterations = 3

Um.  Clearly wrong.

> WebKitTools/Scripts/webkitpy/tool/commands/queuestest.py:83
> +    def assert_queue_outputs(self, queue, args=None, work_item=None, expected_stdout=None, expected_stderr=None, expected_exceptions=None, options=None, tool=MockTool()):

setting tool=MockTool() is wrong here.  That will share an instance of MockTool() for all callers!
Comment 3 Adam Barth 2010-10-13 22:05:01 PDT 
Committed r69737: <http://trac.webkit.org/changeset/69737>