Bug 47649 – Text test conversion: editing/spelling/spelling-linebreak.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Hajime Morrita]

Would convert a pixel test into text based test.

[Hajime Morrita]

Created attachment 71548 [details]
Patch

[Tony Chang]

Comment on attachment 71548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71548&action=review

> LayoutTests/editing/spelling/spelling-linebreak.html:58
> +editingTest();

Maybe you can use runDumpAsTextEditingTest() in editing.js?

[Hajime Morrita]

Hi Tony, 
Thanks you for reviewing!

> > LayoutTests/editing/spelling/spelling-linebreak.html:58
> > +editingTest();
> 
> Maybe you can use runDumpAsTextEditingTest() in editing.js?
Initially i used it because my source of copy is doing it, 
But it also contains delegate related dumps, so I changed to do it myself
to skip the delegate related dumps.

[Hajime Morrita]

Committed r70429: <http://trac.webkit.org/changeset/70429>

[Ryosuke Niwa]

(In reply to comment #3)
> Hi Tony, 
> Thanks you for reviewing!
> 
> > > LayoutTests/editing/spelling/spelling-linebreak.html:58
> > > +editingTest();
> > 
> > Maybe you can use runDumpAsTextEditingTest() in editing.js?
> Initially i used it because my source of copy is doing it, 
> But it also contains delegate related dumps, so I changed to do it myself
> to skip the delegate related dumps.

FYI, runDumpAsTextEditingTest takes a boolean argument to enable editing delegates.

[WebKit Review Bot]

http://trac.webkit.org/changeset/70429 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
editing/spelling/spelling-linebreak.html