Bug 47643 – [Chromium] Support FileSystem in chromium DRT

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Kinuko Yasuda]

[Chromium] Enable FileSystem for chromium DRT

[Kinuko Yasuda]

Created attachment 70698 [details]
Patch

[James Robinson]

Hmm, still getting timeouts on many tests locally (chromium linux)

[Kinuko Yasuda]

(In reply to comment #2)
> Hmm, still getting timeouts on many tests locally (chromium linux)

I'm building the tests locally now... will look into them more closely.

[James Robinson]

Comment on attachment 70698 [details]
Patch

OK, let's try to understand what is going on before landing stuff.

[Kinuko Yasuda]

Ok I got it now and got it working locally.  It'll need more code (and support code in chromium) - I'll update the patch when other code becomes ready.

[James Robinson]

Comment on attachment 70698 [details]
Patch

clearing flags, will need more code

[Kinuko Yasuda]

Created attachment 71247 [details]
Patch

[Kinuko Yasuda]

Committed r70796: <http://trac.webkit.org/changeset/70796>

[Dimitri Glazkov (Google)]

It's really weird, but after landing this change, the Chromium Win tester (http://build.webkit.org/waterfall?show=Chromium%20Win%20Release%20(Tests) ) never ever finishes. When logging on into it locally, I see three DumpRenderTree.exe that are still running, even though the log says the testing is finished. Can you please investigate?

[Dimitri Glazkov (Google)]

(In reply to comment #9)
> It's really weird, but after landing this change, the Chromium Win tester (http://build.webkit.org/waterfall?show=Chromium%20Win%20Release%20(Tests) ) never ever finishes. When logging on into it locally, I see three DumpRenderTree.exe that are still running, even though the log says the testing is finished. Can you please investigate?

If I kill the running DumpRenderTree.exe processes by hand, layout test task finishes as if nothing went wrong.

cc: Ojan -- this is why the Chromium Win bot was not delivering results.

[Dimitri Glazkov (Google)]

(In reply to comment #10)
> (In reply to comment #9)
> > It's really weird, but after landing this change, the Chromium Win tester (http://build.webkit.org/waterfall?show=Chromium%20Win%20Release%20(Tests) ) never ever finishes. When logging on into it locally, I see three DumpRenderTree.exe that are still running, even though the log says the testing is finished. Can you please investigate?
> 
> If I kill the running DumpRenderTree.exe processes by hand, layout test task finishes as if nothing went wrong.
> 
> cc: Ojan -- this is why the Chromium Win bot was not delivering results.

I rd /s/q WebKit/chromium/third_party on that bot and kicked it, let's see what will happen. Kinuko, can you investigate locally if you can run DRT tests to completion on Win?

[Dimitri Glazkov (Google)]

(In reply to comment #11)
> (In reply to comment #10)
> > (In reply to comment #9)
> > > It's really weird, but after landing this change, the Chromium Win tester (http://build.webkit.org/waterfall?show=Chromium%20Win%20Release%20(Tests) ) never ever finishes. When logging on into it locally, I see three DumpRenderTree.exe that are still running, even though the log says the testing is finished. Can you please investigate?
> > 
> > If I kill the running DumpRenderTree.exe processes by hand, layout test task finishes as if nothing went wrong.
> > 
> > cc: Ojan -- this is why the Chromium Win bot was not delivering results.
> 
> I rd /s/q WebKit/chromium/third_party on that bot and kicked it, let's see what will happen. Kinuko, can you investigate locally if you can run DRT tests to completion on Win?

It didn't help.

[Kinuko Yasuda]

(In reply to comment #11)
> (In reply to comment #10)
> > (In reply to comment #9)
> > > It's really weird, but after landing this change, the Chromium Win tester (http://build.webkit.org/waterfall?show=Chromium%20Win%20Release%20(Tests) ) never ever finishes. When logging on into it locally, I see three DumpRenderTree.exe that are still running, even though the log says the testing is finished. Can you please investigate?
> > 
> > If I kill the running DumpRenderTree.exe processes by hand, layout test task finishes as if nothing went wrong.
> > 
> > cc: Ojan -- this is why the Chromium Win bot was not delivering results.
> 
> I rd /s/q WebKit/chromium/third_party on that bot and kicked it, let's see what will happen. Kinuko, can you investigate locally if you can run DRT tests to completion on Win?

Sure I will investigate this one locally.

[Kinuko Yasuda]

(In reply to comment #13)
> (In reply to comment #11)
> > (In reply to comment #10)
> > > (In reply to comment #9)
> > > > It's really weird, but after landing this change, the Chromium Win tester (http://build.webkit.org/waterfall?show=Chromium%20Win%20Release%20(Tests) ) never ever finishes. When logging on into it locally, I see three DumpRenderTree.exe that are still running, even though the log says the testing is finished. Can you please investigate?
> > > 
> > > If I kill the running DumpRenderTree.exe processes by hand, layout test task finishes as if nothing went wrong.
> > > 
> > > cc: Ojan -- this is why the Chromium Win bot was not delivering results.
> > 
> > I rd /s/q WebKit/chromium/third_party on that bot and kicked it, let's see what will happen. Kinuko, can you investigate locally if you can run DRT tests to completion on Win?
> 
> Sure I will investigate this one locally.

Currently I'm building DRT on my Win but it's taking time.  Please ping me if you think this change must be reverted before further investigation.  Thanks,

[Dimitri Glazkov (Google)]

(In reply to comment #12)
> (In reply to comment #11)
> > (In reply to comment #10)
> > > (In reply to comment #9)
> > > > It's really weird, but after landing this change, the Chromium Win tester (http://build.webkit.org/waterfall?show=Chromium%20Win%20Release%20(Tests) ) never ever finishes. When logging on into it locally, I see three DumpRenderTree.exe that are still running, even though the log says the testing is finished. Can you please investigate?
> > > 
> > > If I kill the running DumpRenderTree.exe processes by hand, layout test task finishes as if nothing went wrong.
> > > 
> > > cc: Ojan -- this is why the Chromium Win bot was not delivering results.
> > 
> > I rd /s/q WebKit/chromium/third_party on that bot and kicked it, let's see what will happen. Kinuko, can you investigate locally if you can run DRT tests to completion on Win?
> 
> It didn't help.

I've confirmed locally that reverting this doesn't fix the problem.

[Kinuko Yasuda]

(In reply to comment #15)
> (In reply to comment #12)
> > (In reply to comment #11)
> > > (In reply to comment #10)
> > > > (In reply to comment #9)
> > > > > It's really weird, but after landing this change, the Chromium Win tester (http://build.webkit.org/waterfall?show=Chromium%20Win%20Release%20(Tests) ) never ever finishes. When logging on into it locally, I see three DumpRenderTree.exe that are still running, even though the log says the testing is finished. Can you please investigate?
> > > > 
> > > > If I kill the running DumpRenderTree.exe processes by hand, layout test task finishes as if nothing went wrong.
> > > > 
> > > > cc: Ojan -- this is why the Chromium Win bot was not delivering results.
> > > 
> > > I rd /s/q WebKit/chromium/third_party on that bot and kicked it, let's see what will happen. Kinuko, can you investigate locally if you can run DRT tests to completion on Win?
> > 
> > It didn't help.
> 
> I've confirmed locally that reverting this doesn't fix the problem.

Some additional notes...
I got the same results, it hangs with and without this fix), but only if I used cygwin's python 2.5.2.

In my local testing it worked fine (it warned some wedged threads warning though) when I used python 2.6 or 2.7 downloaded from www.python.org.
Also it didn't hang when I ran it with --child-processes=1 flag.  (I found this flag on the thread: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/495546e6919b99e3?pli=1)