Bug 47642 - Label media/video-source-error test SLOW instead of TIMEOUT
Summary: Label media/video-source-error test SLOW instead of TIMEOUT
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-13 17:56 PDT by imasaki
Modified: 2011-09-22 14:51 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.49 KB, patch)
2010-10-13 17:58 PDT, imasaki
eric: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description imasaki 2010-10-13 17:56:24 PDT
Label media/video-source-error test SLOW instead of TIMEOUT
Comment 1 imasaki 2010-10-13 17:58:30 PDT
Created attachment 70695 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-12-10 22:12:26 PST
Comment on attachment 70695 [details]
Patch

OK.
Comment 3 WebKit Review Bot 2010-12-10 22:16:52 PST
Comment on attachment 70695 [details]
Patch

Rejecting attachment 70695 [details] from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--non-interactive', 70695]" exit_code: 2
Last 500 characters of output:
', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1
Parsed 2 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/chromium/test_expectations.txt
Hunk #1 FAILED at 698.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej

Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/6934052
Comment 4 Ojan Vafai 2010-12-13 07:54:47 PST
Comment on attachment 70695 [details]
Patch

I'm skeptical this is correct. When the test passes it takes <1 second (see http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=webkit.org&tests=media%2Fvideo-source-error.html, the empty boxes mean it took < 1 second). That implies that it's not just a slow test and that there is some logic error causing it to timeout. Marking it slow gives it more time to run, but I doubt that it would pass then. Do you understand why it times out sometimes?
Comment 5 Eric Seidel (no email) 2010-12-14 15:15:20 PST
Comment on attachment 70695 [details]
Patch

Patch does not apply.