WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
47641
Restore normal meaning of double-click on patch review page?
https://bugs.webkit.org/show_bug.cgi?id=47641
Summary
Restore normal meaning of double-click on patch review page?
Darin Adler
Reported
2010-10-13 17:45:49 PDT
I think that clicking on line numbers is a fine way to select ranges to code to comment on. I find the double-click-to-comment behavior frustrating. I want to select words from the source code and paste them into my comments, but I end up creating new empty comments. Can we remove the double-clicking behavior?
Attachments
Patch
(1.60 KB, patch)
2010-11-08 14:10 PST
,
Adam Barth
eric
: review+
eric
: commit-queue+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2010-11-07 16:27:38 PST
Do you still feel this way, or have you gotten used to double-click-to-comment?
Alexey Proskuryakov
Comment 2
2010-11-07 20:51:30 PST
I'm not the original reporter, but this is still an issue for me.
Darin Adler
Comment 3
2010-11-08 10:17:51 PST
(In reply to
comment #1
)
> Do you still feel this way, or have you gotten used to double-click-to-comment?
Yes. I feel it more strongly now since I have used the patch review page much more. I never use double click to comment. I click on the line numbers instead, which is quite convenient. I occasionally get an unexpected comment box, then when mentally reviewing what I had just done I realize that I double clicked. I am accustomed to using double click to select words anywhere I can select text, and it’s useful to select parts of the patch to paste into review comments or search. I run into this much more often now than back in October when I wrote the bug report. So much that I was about to write a bug report about it this week, not remembering I had already done so.
Adam Barth
Comment 4
2010-11-08 10:41:38 PST
Okiedokes. I'll remove the behavior then. Thanks.
Adam Barth
Comment 5
2010-11-08 14:10:12 PST
Created
attachment 73280
[details]
Patch
Eric Seidel (no email)
Comment 6
2010-11-08 14:12:45 PST
Comment on
attachment 73280
[details]
Patch I likes it!
Adam Barth
Comment 7
2010-11-08 14:18:31 PST
Committed
r71570
: <
http://trac.webkit.org/changeset/71570
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug