I think that clicking on line numbers is a fine way to select ranges to code to comment on. I find the double-click-to-comment behavior frustrating. I want to select words from the source code and paste them into my comments, but I end up creating new empty comments.
Can we remove the double-clicking behavior?
Do you still feel this way, or have you gotten used to double-click-to-comment?
I'm not the original reporter, but this is still an issue for me.
(In reply to comment #1)
> Do you still feel this way, or have you gotten used to double-click-to-comment?
Yes. I feel it more strongly now since I have used the patch review page much more.
I never use double click to comment. I click on the line numbers instead, which is quite convenient.
I occasionally get an unexpected comment box, then when mentally reviewing what I had just done I realize that I double clicked. I am accustomed to using double click to select words anywhere I can select text, and it’s useful to select parts of the patch to paste into review comments or search.
I run into this much more often now than back in October when I wrote the bug report. So much that I was about to write a bug report about it this week, not remembering I had already done so.
Okiedokes. I'll remove the behavior then. Thanks.
Created attachment 73280 [details]
Comment on attachment 73280 [details]
I likes it!
Committed r71570: <http://trac.webkit.org/changeset/71570>