Bug 47635 - Add a FindIndicator class
Summary: Add a FindIndicator class
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
Depends on:
Reported: 2010-10-13 16:27 PDT by Anders Carlsson
Modified: 2010-10-15 10:27 PDT (History)
1 user (show)

See Also:

Patch (28.37 KB, patch)
2010-10-13 17:14 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-10-13 16:27:54 PDT
Add a FindIndicator class
Comment 1 Anders Carlsson 2010-10-13 17:14:11 PDT
Created attachment 70687 [details]
Comment 2 WebKit Review Bot 2010-10-13 17:16:57 PDT
Attachment 70687 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/FindIndicator.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/UIProcess/FindIndicator.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 2 in 19 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2010-10-15 10:27:54 PDT
Committed r69862: <http://trac.webkit.org/changeset/69862>