WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
47635
Add a FindIndicator class
https://bugs.webkit.org/show_bug.cgi?id=47635
Summary
Add a FindIndicator class
Anders Carlsson
Reported
2010-10-13 16:27:54 PDT
Add a FindIndicator class
Attachments
Patch
(28.37 KB, patch)
2010-10-13 17:14 PDT
,
Anders Carlsson
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2010-10-13 17:14:11 PDT
Created
attachment 70687
[details]
Patch
WebKit Review Bot
Comment 2
2010-10-13 17:16:57 PDT
Attachment 70687
[details]
did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/UIProcess/FindIndicator.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/UIProcess/FindIndicator.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 2 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3
2010-10-15 10:27:54 PDT
Committed
r69862
: <
http://trac.webkit.org/changeset/69862
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug