Bug 47633 – [chromium] compile TestNetscapePlugIn on Chromium mac

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tony Chang]

[chromium] compile TestNetscapePlugIn on Chromium mac

[Tony Chang]

Created attachment 70680 [details]
Patch

[Tony Chang]

I talked to eseidel and he showed me how gtk/qt handle compiling this using ForwardingHeaders.  This avoids having to change the include paths.

This patch only compiles a plugin, it doesn't use it in DRT yet.

[Kent Tamura]

Comment on attachment 70680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70680&action=review

> WebKitTools/DumpRenderTree/DumpRenderTree.gypi:47
> +        'test_plugin_files': [

nit: Our gyp sorting rule is probably ASCII order or case-insensitive alphabetical order. The order of TestObject.h -> main.cpp -> Tests/ looks not good.

[Tony Chang]

Committed r69809: <http://trac.webkit.org/changeset/69809>

[Tony Chang]

(In reply to comment #3)
> (From update of attachment 70680 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=70680&action=review
> 
> > WebKitTools/DumpRenderTree/DumpRenderTree.gypi:47
> > +        'test_plugin_files': [
> 
> nit: Our gyp sorting rule is probably ASCII order or case-insensitive alphabetical order. The order of TestObject.h -> main.cpp -> Tests/ looks not good.

Good idea.  I switched to ASCII ordering which puts main.cpp at the end of the list.

[Tony Chang]

Committed r69870: <http://trac.webkit.org/changeset/69870>

[Tony Chang]

(In reply to comment #6)
> Committed r69870: <http://trac.webkit.org/changeset/69870>

Relanded with a fixed include dir (so we can compile in a chromium only checkout).