Bug 47625 - Run layout tests when GL fails to initialize
Summary: Run layout tests when GL fails to initialize
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-13 15:30 PDT by Hin-Chung Lam
Modified: 2014-10-22 10:31 PDT (History)
5 users (show)

See Also:


Attachments
patch (2.20 KB, patch)
2010-10-13 15:37 PDT, Hin-Chung Lam
levin: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hin-Chung Lam 2010-10-13 15:30:49 PDT
test_shell and DRT uses Mesa which doesn't test that case when GL fails to initialize.

The first step is to have the tools be able to fail the initialization when running the layout test.

The second step is to allow layout test to control that in the script.
Comment 1 Hin-Chung Lam 2010-10-13 15:37:44 PDT
Created attachment 70674 [details]
patch
Comment 2 James Robinson 2010-10-13 15:41:41 PDT
Do we want --use-gl or some flag to explicitly toggle whether context initialization fails?  This flag doesn't seem to describe what it does very well.
Comment 3 Victoria Kirst 2010-10-13 15:43:16 PDT
(In reply to comment #2)
> Do we want --use-gl or some flag to explicitly toggle whether context initialization fails?  This flag doesn't seem to describe what it does very well.

I agree, I think it would make more sense to have an explicit flag for testing the case where the GL initialization fails.
Comment 4 Hin-Chung Lam 2010-10-13 15:47:05 PDT
what about --no-gl-context?
Comment 5 David Levin 2010-10-13 20:47:13 PDT
Comment on attachment 70674 [details]
patch

Based on comments already in the bug.