Bug 47610 - Revert changes to WebViewImpl in r69633
Summary: Revert changes to WebViewImpl in r69633
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-13 11:50 PDT by Kenneth Russell
Modified: 2010-10-13 13:30 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.88 KB, patch)
2010-10-13 11:51 PDT, Kenneth Russell
jamesr: review+
kbr: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-10-13 11:50:06 PDT
David Levin pointed out that the change to WebViewImpl in http://trac.webkit.org/changeset/69633 incorrectly used PassRefPtr for a local variable instead of RefPtr. I thought I had seen an assertion failure in this code change in http://trac.webkit.org/changeset/69624 but after reverting it it seems not.
Comment 1 Kenneth Russell 2010-10-13 11:51:52 PDT
Created attachment 70643 [details]
Patch
Comment 2 James Robinson 2010-10-13 12:01:18 PDT
Comment on attachment 70643 [details]
Patch

Yup!
Comment 3 Kenneth Russell 2010-10-13 13:30:15 PDT
Committed r69693: <http://trac.webkit.org/changeset/69693>