Bug 47605 - Add DATABASE guard on code using DatabaseAuthorizer.
Summary: Add DATABASE guard on code using DatabaseAuthorizer.
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-13 11:05 PDT by Hyung Song
Modified: 2010-12-13 00:38 PST (History)
5 users (show)

See Also:

Attachments
Patch. Add DATABASE guard. (2.27 KB, patch)
2010-10-13 11:25 PDT, Hyung Song 		eric: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hyung Song 2010-10-13 11:05:35 PDT 
BrewMP will use sqlite3 without enabling DATABASE.
So DatabaseAuthorizer is not used.
Comment 1 Hyung Song 2010-10-13 11:25:08 PDT 
Created attachment 70634 [details]
Patch. Add DATABASE guard.
Comment 2 Dumitru Daniliuc 2010-10-14 10:54:38 PDT 
Comment on attachment 70634 [details]
Patch. Add DATABASE guard.

instead of hiding the authorizer behind the ENABLE(DATABASE) switch, i think we should rather hide it behind the BREWMP port switch.
Comment 3 Eric Seidel (no email) 2010-10-14 10:55:06 PDT 
This seems like it will fail due to unused parameter warnings.

Ideally a database person would comment here.
Comment 4 Kwang Yul Seo 2010-11-14 16:47:34 PST 
Ping!
Comment 5 Eric Seidel (no email) 2010-12-13 00:38:07 PST 
Comment on attachment 70634 [details]
Patch. Add DATABASE guard.

This is going to fail due to an unused param.  There is an UNUSED_ARG macro or UNUSED_PARAM or something like that.