UNCONFIRMED47605
Add DATABASE guard on code using DatabaseAuthorizer. 
https://bugs.webkit.org/show_bug.cgi?id=47605
Summary Add DATABASE guard on code using DatabaseAuthorizer.
Hyung Song
Reported 2010-10-13 11:05:35 PDT
BrewMP will use sqlite3 without enabling DATABASE. So DatabaseAuthorizer is not used.
Attachments
Patch. Add DATABASE guard. (2.27 KB, patch)
2010-10-13 11:25 PDT, Hyung Song 		eric: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hyung Song
Comment 1 2010-10-13 11:25:08 PDT
Created attachment 70634 [details] Patch. Add DATABASE guard.
Dumitru Daniliuc
Comment 2 2010-10-14 10:54:38 PDT
Comment on attachment 70634 [details] Patch. Add DATABASE guard. instead of hiding the authorizer behind the ENABLE(DATABASE) switch, i think we should rather hide it behind the BREWMP port switch.
Eric Seidel (no email)
Comment 3 2010-10-14 10:55:06 PDT
This seems like it will fail due to unused parameter warnings. Ideally a database person would comment here.
Kwang Yul Seo
Comment 4 2010-11-14 16:47:34 PST
Ping!
Eric Seidel (no email)
Comment 5 2010-12-13 00:38:07 PST
Comment on attachment 70634 [details] Patch. Add DATABASE guard. This is going to fail due to an unused param. There is an UNUSED_ARG macro or UNUSED_PARAM or something like that.
Note You need to log in before you can comment on or make changes to this bug.