Bug 47588 - [GTK] Small cleanup in PluginViewGtk
Summary: [GTK] Small cleanup in PluginViewGtk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-13 06:37 PDT by Xan Lopez
Modified: 2010-10-14 12:29 PDT (History)
3 users (show)

See Also:

Attachments
cleanup.diff (4.53 KB, patch)
2010-10-13 06:40 PDT, Xan Lopez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2010-10-13 06:37:53 PDT 
SSIA.
Comment 1 Xan Lopez 2010-10-13 06:40:02 PDT 
Created attachment 70605 [details]
cleanup.diff
Comment 2 Martin Robinson 2010-10-13 19:01:59 PDT 
How did this code originate? Is it important to preserve the assertion?
Comment 3 Xan Lopez 2010-10-13 23:53:02 PDT 
(In reply to comment #2)
> How did this code originate? Is it important to preserve the assertion?

The actualDepth was used before to see if we have an alpha channel, but in the current code we use cairo_surface_get_content for that. We can still keep the assertion (doing it differently) if you think it's important, I'm not very sure that it is.
Comment 4 Martin Robinson 2010-10-13 23:55:34 PDT 
Comment on attachment 70605 [details]
cleanup.diff

Seems reasonable.
Comment 5 WebKit Commit Bot 2010-10-14 12:29:51 PDT 
Comment on attachment 70605 [details]
cleanup.diff

Clearing flags on attachment: 70605

Committed r69793: <http://trac.webkit.org/changeset/69793>
Comment 6 WebKit Commit Bot 2010-10-14 12:29:56 PDT 
All reviewed patches have been landed.  Closing bug.