Bug 47584 - Add wtf/text/StringConcatenate
Summary: Add wtf/text/StringConcatenate
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
Depends on:
Blocks: 18994
  Show dependency treegraph
Reported: 2010-10-13 03:19 PDT by Nikolas Zimmermann
Modified: 2010-10-14 05:05 PDT (History)
0 users

See Also:

Patch (55.82 KB, patch)
2010-10-13 03:28 PDT, Nikolas Zimmermann
no flags Details | Formatted Diff | Diff
Patch v2 (71.37 KB, patch)
2010-10-13 03:39 PDT, Nikolas Zimmermann
krit: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-10-13 03:19:12 PDT
Move JSC/runtime/StringConcatenate to wtf/text, make it work for Strings too. Add a special JSC/runtime/UStringConcatenate class that inherits from StringConcatenate, and extends it for UString.
Exactly the same design that has been done while refactoring StringBuilder.

The UString variants can all be removed as soon as WTF::String & JSC::UString converge.
Comment 1 Nikolas Zimmermann 2010-10-13 03:28:11 PDT
Created attachment 70594 [details]

Please wait for EWS before reviewing.
Comment 2 Nikolas Zimmermann 2010-10-13 03:39:11 PDT
Created attachment 70596 [details]
Patch v2

I ran svn-create-patch from within JSC, maybe that's why the bots can't apply the patch?
Comment 3 Dirk Schulze 2010-10-13 07:19:26 PDT
Comment on attachment 70596 [details]
Patch v2

LGTM. r=me
Comment 4 Nikolas Zimmermann 2010-10-13 07:51:16 PDT
Landed in r69663.