Bug 47563 - Pass platform path (rather than virtual path) when creating File from FileEntry
Summary: Pass platform path (rather than virtual path) when creating File from FileEntry
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-12 17:24 PDT by Kinuko Yasuda
Modified: 2010-10-12 19:27 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2010-10-12 17:39 PDT, Kinuko Yasuda 		no flags Details | Formatted Diff | Diff
Patch (1.33 KB, patch)
2010-10-12 17:45 PDT, Kinuko Yasuda 		jianli: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kinuko Yasuda 2010-10-12 17:24:31 PDT 
Pass platform path (irather than virtual path) when creating File from FileEntry.
Comment 1 Kinuko Yasuda 2010-10-12 17:39:51 PDT 
Created attachment 70575 [details]
Patch
Comment 2 Kinuko Yasuda 2010-10-12 17:45:50 PDT 
Created attachment 70576 [details]
Patch

Sorry I sent an wrong one.
Comment 3 Eric U. 2010-10-12 17:56:31 PDT 
Comment on attachment 70576 [details]
Patch

LGTM.
Comment 4 Jian Li 2010-10-12 18:02:49 PDT 
One suggestion. Consider renaming m_fullPath in EntryBase to m_virtualPath or m_fullVirtualPath to improve reability and avoid future mistake. Or at least you can add the comment in EntryBase.h.
Comment 5 Kinuko Yasuda 2010-10-12 18:40:43 PDT 
(In reply to comment #4)
> One suggestion. Consider renaming m_fullPath in EntryBase to m_virtualPath or m_fullVirtualPath to improve reability and avoid future mistake. Or at least you can add the comment in EntryBase.h.

Thanks, I'll make a separate patch to rename all.
Comment 6 Kinuko Yasuda 2010-10-12 18:59:44 PDT 
(In reply to comment #5)
> (In reply to comment #4)
> > One suggestion. Consider renaming m_fullPath in EntryBase to m_virtualPath or m_fullVirtualPath to improve reability and avoid future mistake. Or at least you can add the comment in EntryBase.h.
> 
> Thanks, I'll make a separate patch to rename all.

Hmm, on the second thought m_fullPath was named after FileEntry.fullPath attribute.  I'm going to put the comment to indicate it's virtual path.
Comment 7 Kinuko Yasuda 2010-10-12 19:27:04 PDT 
Committed r69634: <http://trac.webkit.org/changeset/69634>