Bug 47559 - Start fleshing out find page overlays
Summary: Start fleshing out find page overlays
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-12 15:39 PDT by Anders Carlsson
Modified: 2010-10-12 16:11 PDT (History)
2 users (show)

See Also:


Attachments
Patch (24.62 KB, patch)
2010-10-12 15:46 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-10-12 15:39:26 PDT
Start fleshing out find page overlays
Comment 1 Anders Carlsson 2010-10-12 15:46:00 PDT
Created attachment 70568 [details]
Patch
Comment 2 WebKit Review Bot 2010-10-12 15:49:21 PDT
Attachment 70568 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/WebPage/PageOverlay.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebKit2/WebProcess/WebPage/FindPageOverlay.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/WebPage/PageOverlay.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 3 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2010-10-12 16:03:37 PDT
Attachment 70568 [details] did not build on qt:
Build output: http://queues.webkit.org/results/4354027
Comment 4 Sam Weinig 2010-10-12 16:07:20 PDT
Comment on attachment 70568 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70568&action=review

> WebKit2/WebProcess/WebPage/FindController.cpp:72
> +    }

The braces are not necessary here.

> WebKit2/WebProcess/WebPage/FindController.cpp:84
> +    ASSERT(shouldShowOverlay);

This ASSERT is not adding anything.
Comment 5 Anders Carlsson 2010-10-12 16:11:09 PDT
Committed r69616: <http://trac.webkit.org/changeset/69616>