Bug 47559 – Start fleshing out find page overlays

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Start fleshing out find page overlays

[Anders Carlsson]

Created attachment 70568 [details]
Patch

[WebKit Review Bot]

Attachment 70568 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/WebPage/PageOverlay.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebKit2/WebProcess/WebPage/FindPageOverlay.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/WebPage/PageOverlay.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 3 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Attachment 70568 [details] did not build on qt:
Build output: http://queues.webkit.org/results/4354027

[Sam Weinig]

Comment on attachment 70568 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70568&action=review

> WebKit2/WebProcess/WebPage/FindController.cpp:72
> +    }

The braces are not necessary here.

> WebKit2/WebProcess/WebPage/FindController.cpp:84
> +    ASSERT(shouldShowOverlay);

This ASSERT is not adding anything.

[Anders Carlsson]

Committed r69616: <http://trac.webkit.org/changeset/69616>