Bug 47553 - Add a simple Find UI to MiniBrowser
Summary: Add a simple Find UI to MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-12 13:15 PDT by Anders Carlsson
Modified: 2010-10-12 13:28 PDT (History)
0 users

See Also:

Attachments
Patch (136.07 KB, patch)
2010-10-12 13:16 PDT, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-10-12 13:15:18 PDT 
Add a simple Find UI to MiniBrowser
Comment 1 Anders Carlsson 2010-10-12 13:16:27 PDT 
Created attachment 70559 [details]
Patch
Comment 2 Sam Weinig 2010-10-12 13:20:26 PDT 
Comment on attachment 70559 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70559&action=review

> WebKitTools/MiniBrowser/mac/BrowserWindowController.m:667
> +- (IBAction)performFindPanelAction:(id)sender {
> +    [findPanelWindow makeKeyAndOrderFront:sender];
> +}
> +
> +- (IBAction)find:(id)sender {
> +    WKStringRef string = WKStringCreateWithCFString((CFStringRef)[sender stringValue]);

The { should be on the next line.
Comment 3 Anders Carlsson 2010-10-12 13:28:37 PDT 
Committed r69595: <http://trac.webkit.org/changeset/69595>