RESOLVED FIXED47543
[Qt] Simplify code generation in WebKit2/DerivedSources.pro 
https://bugs.webkit.org/show_bug.cgi?id=47543
Summary [Qt] Simplify code generation in WebKit2/DerivedSources.pro
Csaba Osztrogonác
Reported 2010-10-12 05:55:18 PDT
It would be great if we have only two generator rules similar to DerivedSources.make instead of copy/paste code: one for headers and one for sources. DerivedSources.make: ... MESSAGE_RECEIVERS = \ PluginControllerProxy \ PluginProcess \ PluginProcessProxy \ PluginProxy \ WebPage \ WebPageProxy \ WebProcess \ WebProcessConnection \ # ... all : \ $(MESSAGE_RECEIVERS:%=%MessageReceiver.cpp) \ $(MESSAGE_RECEIVERS:%=%Messages.h) \ # %MessageReceiver.cpp : %.messages.in $(SCRIPTS) @echo Generating messages header for $*... @python $(WebKit2)/Scripts/generate-message-receiver.py $< > $@ %Messages.h : %.messages.in $(SCRIPTS) @echo Generating message receiver for $*... @python $(WebKit2)/Scripts/generate-messages-header.py $< > $@
Attachments
proposed patch (8.80 KB, patch)
2010-10-13 05:46 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2010-10-13 05:46:13 PDT
Created attachment 70603 [details] proposed patch
Csaba Osztrogonác
Comment 2 2010-10-13 06:09:46 PDT
Comment on attachment 70603 [details] proposed patch Clearing flags on attachment: 70603 Committed r69653: <http://trac.webkit.org/changeset/69653>
Csaba Osztrogonác
Comment 3 2010-10-13 06:09:55 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 4 2010-10-13 06:58:24 PDT
http://trac.webkit.org/changeset/69653 might have broken Qt Linux Release The following tests are not passing: fast/events/spatial-navigation/snav-clipped-overflowed-content.html
Note You need to log in before you can comment on or make changes to this bug.