commit-queue should reject patches which fail stylebot
Per Oliver's request on webkit-reviewers. Makes sense to me.
Should be easy to make the cq check stylebot status before landing. Alternatively we could have the style-bot simply cq- any patch which fails. They're slightly different meanings. Not sure which is the more useful.
After further thought, we've decided to make the EWSes reject from the cq, but not the style-bot.
We can always add the style-bot later, but breaking the build or tests is a better reason not to land than breaking style rules atm. :)
Created attachment 92391 [details]
To be clear, what this does is when an EWS fails, it marks the patch as cq-. That *does not* prevent someone from marking it cq+ later, or landing manually. So this is mostly just a stronger form of advisement. I don't think most people will notice, but hopefullly it will further convey the idea that patches shouldn't break builders. :)
Also this moves us one step closer to making test running asynchronous from landing (which will make the cq blazing fast, and is more like how a real person codes).
Comment on attachment 92391 [details]
Clearing flags on attachment: 92391
Committed r85871: <http://trac.webkit.org/changeset/85871>
All reviewed patches have been landed. Closing bug.
http://trac.webkit.org/changeset/85871 might have broken GTK Linux 32-bit Debug
The following tests are not passing: