Bug 47530 - IndexedDB should fire some errors synchronously
Summary: IndexedDB should fire some errors synchronously
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Jeremy Orlow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-11 18:28 PDT by Jeremy Orlow
Modified: 2010-10-13 17:39 PDT (History)
5 users (show)

See Also:


Attachments
Patch (132.75 KB, patch)
2010-10-11 18:44 PDT, Jeremy Orlow
no flags Details | Formatted Diff | Diff
Patch (131.53 KB, patch)
2010-10-13 10:26 PDT, Jeremy Orlow
no flags Details | Formatted Diff | Diff
Patch (131.42 KB, patch)
2010-10-13 10:55 PDT, Jeremy Orlow
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2010-10-11 18:28:20 PDT
IndexedDB should fire some errors synchronously
Comment 1 Jeremy Orlow 2010-10-11 18:44:46 PDT
Created attachment 70509 [details]
Patch
Comment 2 WebKit Review Bot 2010-10-11 21:43:51 PDT
Attachment 70509 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/4337039
Comment 3 Jeremy Orlow 2010-10-13 00:24:23 PDT
Andrei, can you please review this?
Comment 4 Jeremy Orlow 2010-10-13 10:26:41 PDT
Created attachment 70622 [details]
Patch
Comment 5 Nate Chapin 2010-10-13 10:40:38 PDT
Comment on attachment 70622 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70622&action=review

> LayoutTests/storage/indexeddb/objectstore-basics.html:64
>          shouldBeNull("index"); // Returning null is wrong, but less wrong than returning an actual object!

Does this null check still make sense if we already know we're failing?  It's not entirely clear to me.

> LayoutTests/storage/indexeddb/objectstore-basics.html:87
> +        shouldBeNull("index"); // Returning null is wrong, but less wrong than returning an actual object!

Same as above.
Comment 6 Jeremy Orlow 2010-10-13 10:42:19 PDT
(In reply to comment #5)
> (From update of attachment 70622 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=70622&action=review
> 
> > LayoutTests/storage/indexeddb/objectstore-basics.html:64
> >          shouldBeNull("index"); // Returning null is wrong, but less wrong than returning an actual object!
> 
> Does this null check still make sense if we already know we're failing?  It's not entirely clear to me.
> 
> > LayoutTests/storage/indexeddb/objectstore-basics.html:87
> > +        shouldBeNull("index"); // Returning null is wrong, but less wrong than returning an actual object!
> 
> Same as above.

I could go either way, but I'm happy to delete it.
Comment 7 Jeremy Orlow 2010-10-13 10:55:49 PDT
Created attachment 70629 [details]
Patch
Comment 8 WebKit Commit Bot 2010-10-13 17:39:48 PDT
Comment on attachment 70629 [details]
Patch

Clearing flags on attachment: 70629

Committed r69721: <http://trac.webkit.org/changeset/69721>
Comment 9 WebKit Commit Bot 2010-10-13 17:39:55 PDT
All reviewed patches have been landed.  Closing bug.