Bug 47528 - new-run-webkit-tests: 'webkit-patch skipped-ports' introduced bad layering
Summary: new-run-webkit-tests: 'webkit-patch skipped-ports' introduced bad layering
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-11 18:12 PDT by Dirk Pranke
Modified: 2012-04-11 17:13 PDT (History)
5 users (show)

See Also:


Attachments
Patch (11.62 KB, patch)
2012-04-11 16:56 PDT, Dirk Pranke
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-10-11 18:12:29 PDT
bug 42832 / r66872 introduced some unfortunate layering/dependency violations, by making the Port classes depend on the test_expectations library. This should be cleaned up by adding a generic routine that depends on both modules.
Comment 1 Dirk Pranke 2012-04-11 16:56:04 PDT
Created attachment 136789 [details]
Patch
Comment 2 Dirk Pranke 2012-04-11 17:13:52 PDT
Committed r113927: <http://trac.webkit.org/changeset/113927>