Bug 47519 – [FileSystem] Add ability to pass a bool to create or not create root path while opening filesystem.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Kavita Kanetkar]

Currently FileSyetem will create root path of the file system if one does not exist. There are cases such as Inspector opening the file system.
In these cases we do not want to create the file system root paths.

[Kavita Kanetkar]

Created attachment 70508 [details]
patch

[Dumitru Daniliuc]

Comment on attachment 70508 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70508&action=review

> WebKit/chromium/src/LocalFileSystemChromium.cpp:71
> +        webWorker->openFileSystem(static_cast<WebFileSystem::Type>(type), size, create, new WebFileSystemCallbacksImpl(callbacks, context, synchronous), create, synchronous);

why do we need to pass the 'create' arg twice?

[Kavita Kanetkar]

Created attachment 70565 [details]
patch2

Simplified this. Added new method so that chromium uses them. Will upload another patch for WebCore to use new method signatures.
Thanks for the review.

[Dumitru Daniliuc]

Comment on attachment 70565 [details]
patch2

View in context: https://bugs.webkit.org/attachment.cgi?id=70565&action=review

r=me.

> WebKit/chromium/ChangeLog:5
> +        [FileSystem] Add ability to pass a bool to create or not create root path while opening filesystem.

please update description.

[Dumitru Daniliuc]

Comment on attachment 70565 [details]
patch2

oops, ignore my comment. cq+'ing.

[WebKit Commit Bot]

Comment on attachment 70565 [details]
patch2

Clearing flags on attachment: 70565

Committed r69609: <http://trac.webkit.org/changeset/69609>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/69609 might have broken Chromium Win Release

[Eric Seidel (no email)]

enums are always better than bools.