Bug 47489 - WebProcess ASSERTs with a null application cache dir creation parameter
Summary: WebProcess ASSERTs with a null application cache dir creation parameter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-11 07:34 PDT by Balazs Kelemen
Modified: 2010-10-11 10:08 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.33 KB, patch)
2010-10-11 07:36 PDT, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
Patch (1.33 KB, patch)
2010-10-11 09:52 PDT, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2010-10-11 07:34:06 PDT 
The app cache dir path we get from the UI side should be chekced and ignored if it is a null or empty string.
Comment 1 Balazs Kelemen 2010-10-11 07:36:40 PDT 
Created attachment 70434 [details]
Patch
Comment 2 Csaba Osztrogonác 2010-10-11 07:38:29 PDT 
Comment on attachment 70434 [details]
Patch

LGTM, r=me
Comment 3 Balazs Kelemen 2010-10-11 07:40:55 PDT 
Comment on attachment 70434 [details]
Patch

wrong, does not tests the value just the pointer
Comment 4 Balazs Kelemen 2010-10-11 07:42:27 PDT 
Comment on attachment 70434 [details]
Patch

:)
Comment 5 Balazs Kelemen 2010-10-11 09:52:22 PDT 
Created attachment 70440 [details]
Patch
Comment 6 Balazs Kelemen 2010-10-11 10:08:03 PDT 
Comment on attachment 70440 [details]
Patch

Clearing flags on attachment: 70440

Committed r69503: <http://trac.webkit.org/changeset/69503>
Comment 7 Balazs Kelemen 2010-10-11 10:08:11 PDT 
All reviewed patches have been landed.  Closing bug.