Bug 47479 - [EFL] remove warning
Summary: [EFL] remove warning
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-10 21:49 PDT by Ryuan Choi
Modified: 2010-10-19 05:47 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.04 KB, patch)
2010-10-10 21:51 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2010-10-10 21:49:11 PDT 
There are below warning with -DENABLE_ECORE_X=Off
/workspace/webkit/WebCore/platform/efl/WidgetEfl.cpp:209:5: warning: "HAVE_ECORE_X" is not defined
Comment 1 Ryuan Choi 2010-10-10 21:51:12 PDT 
Created attachment 70422 [details]
Patch
Comment 2 Rafael Antognolli 2010-10-19 05:03:27 PDT 
Good point! The patch is fine.
Comment 3 Lucas De Marchi 2010-10-19 05:16:34 PDT 
Comment on attachment 70422 [details]
Patch

And the tons of -W added to the build system proved to be worth doing :-).
Comment 4 WebKit Commit Bot 2010-10-19 05:47:35 PDT 
Comment on attachment 70422 [details]
Patch

Clearing flags on attachment: 70422

Committed r70051: <http://trac.webkit.org/changeset/70051>
Comment 5 WebKit Commit Bot 2010-10-19 05:47:41 PDT 
All reviewed patches have been landed.  Closing bug.